Fix quit confirmation during debuggin session. #3916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ret2libc
reviewed
Oct 12, 2023
There was a problem hiding this comment.
What if we move the if (debug) code below the
if (rz_config_get_i(r->config, "scr.confirmquit")) {
if (!rz_cons_yesno('n', "Do you want to quit? (Y/n)")) {
continue;
}
}
?
It would need some adjustments, but I think it would make more sense. There's some duplicated code here.
ret2libc
requested changes
Oct 12, 2023
librz/main/rizin.c
Outdated
| if (rz_config_get_i(r->config, "dbg.exitkills") && | ||
| rz_debug_can_kill(r->dbg) && | ||
| rz_cons_yesno('y', "Do you want to kill the process? (Y/n)")) { | ||
| rz_config_set_i(r->config, "scr.confirmquit", false); |
There was a problem hiding this comment.
I understood, here is my approach
What I have done here is
if scr.confirmquit is true, then the program will ask for quit confirmation and continue if n is returned.
if y is returned then the program will ask for to kill the process is and will not continue to the loop in any case.
vanshjangir
force-pushed
the
debug-quitconfirmation
branch
from
be66972 to
148e926
Compare
ret2libc
approved these changes
Oct 13, 2023
ret2libc
requested review from
wargio,
XVilka,
kazarmy and
thestr4ng3r
as code owners
wargio
reviewed
Oct 13, 2023
|
(Closes #3818) |
|
IMO the PR is in good shape. @wargio ? |
vanshjangir
force-pushed
the
debug-quitconfirmation
branch
from
b14d682 to
58229f2
Compare
XVilka
approved these changes
Oct 22, 2023
vanshjangir
force-pushed
the
debug-quitconfirmation
branch
from
aec85eb to
ee14cf9
Compare
wargio
approved these changes
Oct 23, 2023
wargio
changed the title
|
Thank you <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
In
librz/main/rizin.c, when in debugger session the program ask for quit confirmation independent ofscr.confirmquittrue or false.So the quit confirmation when in debug session is removed, and the code for debug session is pasted below the general quit confirm message, Now if user wants to quit then only program will ask to kill the process otherwise the program will just continue
Test plan
...
Closing issues
Closes #3818