Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
I'd like to have
asm.flags.real=true
by default, however one of the problems with having that enabled is that the users cannot easily know what is the flag name they should use to reference the symbol.For example:
It is not immediately clear that the flag name (which should be used in commands like
s
) ismethod.std::vector_int__std::allocator_int___.vector
.The idea is that we want the flag name to be displayed as comment (but only when the real names are displayed!):
These comments are not displayed in visual mode because the user can easily use the "jumpkeys"(the numbers near the calls e.g.
[1]
) to move between functions.Test plan
See attached test.
Moreover, ensure that in visual mode the comments are not displayed.
Closing issues
...