Buffer trim and document #3912
Merged
Buffer trim and document #3912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
createyourpersonalaccount
requested review from
ret2libc and
thestr4ng3r
as code owners
ret2libc
approved these changes
Oct 9, 2023
XVilka
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Good change as is and could be merged. But I wonder if it's better to reuse RzUtil's RzBuf and/or RzStrBuf to reduce code duplication. @ret2libc @wargio @thestr4ng3r what do you think about this?
wargio
approved these changes
Oct 13, 2023
|
agreed with you @XVilka but we could do it in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
We remove unused functions and macros from the buffer header and source file and document the rest.
Test plan
...
Closing issues
...