fix leak in variable_from_die

rizinorg · Jan 8, 2025 · c97d4ee · c97d4ee
1 parent 77e66c0
commit c97d4ee
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/librz/arch/dwarf_process.c b/librz/arch/dwarf_process.c
@@ -1696,12 +1696,14 @@ static bool variable_from_die(
 	RZ_BORROW RZ_IN RZ_NONNULL DwContext *ctx,
 	RZ_BORROW RZ_IN RZ_NONNULL const RzBinDwarfDie *die) {
 	RzAnalysisDwarfVariable v = { 0 };
+	bool res = false;
 	if (!function_var_parse(ctx, NULL, NULL, &v, die, NULL)) {
-		variable_fini(&v);
-		return false;
+		goto beach;
 	}
-
-	return try_create_var_global(ctx, die, &v);
+	res = try_create_var_global(ctx, die, &v);
+beach:
+	variable_fini(&v);
+	return res;
 }
 
 static void die_parse(DwContext *ctx, RzBinDwarfDie *die) {