fix DWARF parsing leaks (#4818)

* fix leak in `variable_from_die` * fix leak in `rz_base_type_clone`
rizinorg · Jan 9, 2025 · b196a1f · b196a1f
1 parent 15690c7
commit b196a1f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/librz/arch/dwarf_process.c b/librz/arch/dwarf_process.c
@@ -1696,12 +1696,14 @@ static bool variable_from_die(
 	RZ_BORROW RZ_IN RZ_NONNULL DwContext *ctx,
 	RZ_BORROW RZ_IN RZ_NONNULL const RzBinDwarfDie *die) {
 	RzAnalysisDwarfVariable v = { 0 };
+	bool res = false;
 	if (!function_var_parse(ctx, NULL, NULL, &v, die, NULL)) {
-		variable_fini(&v);
-		return false;
+		goto beach;
 	}
-
-	return try_create_var_global(ctx, die, &v);
+	res = try_create_var_global(ctx, die, &v);
+beach:
+	variable_fini(&v);
+	return res;
 }
 
 static void die_parse(DwContext *ctx, RzBinDwarfDie *die) {

diff --git a/librz/type/base.c b/librz/type/base.c
@@ -196,6 +196,7 @@ RZ_API RZ_OWN RzBaseType *rz_base_type_clone(RZ_NULLABLE RZ_BORROW RzBaseType *b
 		return NULL;
 	}
 	if (!rz_base_type_clone_into(type, b)) {
+		rz_type_base_type_free(type);
 		return NULL;
 	}
 	return type;