Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DONT APPROVE BEFORE 55! 0.9.9.1 - test_overwrite per column instead of model and fk at_least_one #57

Merged
merged 19 commits into from
Feb 22, 2023
Merged

DONT APPROVE BEFORE 55! 0.9.9.1 - test_overwrite per column instead of model and fk at_least_one #57

merged 19 commits into from
Feb 22, 2023

Conversation

Terroface
Copy link
Collaborator

@Terroface Terroface commented Feb 13, 2023 •
edited
Loading

  • test_overwrite now only affects the columns specified instead of overwriting all the columns for their model
  • the deafult test for fk columns is now dbt_utils.at_least_one

Reasoning

Considerations

@Terroface Terroface marked this pull request as ready for review February 13, 2023 18:58
@Terroface Terroface added the enhancement New feature or request label Feb 13, 2023
@LewisCharlesBaker
Copy link
Collaborator

@Terroface - This looks great. @jack @jordan, we have some customer projects we could update to this method and we'll need to once this is shipped

@Terroface Terroface changed the title 0.9.5 - test_overwrite per column instead of model and fk at_least_one 0.9.7 - test_overwrite per column instead of model and fk at_least_one Feb 21, 2023
@Terroface
Copy link
Collaborator Author

wait to approve this until #55 is approved and merged into this

@Terroface Terroface changed the title 0.9.7 - test_overwrite per column instead of model and fk at_least_one DONT APPROVE BEFORE 55! 0.9.7 - test_overwrite per column instead of model and fk at_least_one Feb 21, 2023
@Terroface Terroface changed the title DONT APPROVE BEFORE 55! 0.9.7 - test_overwrite per column instead of model and fk at_least_one DONT APPROVE BEFORE 55! 0.9.9.1 - test_overwrite per column instead of model and fk at_least_one Feb 22, 2023
@LewisCharlesBaker LewisCharlesBaker merged commit 239c39a into master Feb 22, 2023
@LewisCharlesBaker LewisCharlesBaker mentioned this pull request Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LewisCharlesBaker LewisCharlesBaker LewisCharlesBaker approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Terroface @LewisCharlesBaker