Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/projects api #189

Merged
merged 6 commits into from
Nov 22, 2024
Merged

Dev/projects api #189

merged 6 commits into from
Nov 22, 2024

Conversation

grong0
Copy link
Contributor

@grong0 grong0 commented Nov 10, 2024

it's done !!! check it out

+ new project seed data
+ new project api methods
+ new project api tests
* currently cant test some of the tests because of auth; waiting to rebase off that
+ fixed tests
@grong0 grong0 requested a review from PokeJofeJr4th November 10, 2024 18:26
@grong0 grong0 self-assigned this Nov 10, 2024
@grong0 grong0 linked an issue Nov 10, 2024 that may be closed by this pull request
25 tasks
Copy link
Contributor

@PokeJofeJr4th PokeJofeJr4th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you manually tested? I'm worried the GET routes wouldn't have the right amount of data returned without explicitly using the select clause.

next/prisma/schema.prisma Outdated Show resolved Hide resolved
@grong0
Copy link
Contributor Author

grong0 commented Nov 10, 2024

i did :)

…jects

+ new tests for userProject
+ updated tests to not interfere with userProject tests
@grong0
Copy link
Contributor Author

grong0 commented Nov 10, 2024

Added implementation for contributers on projects.

@grong0 grong0 requested a review from PokeJofeJr4th November 10, 2024 21:39
@2nPlusOne
Copy link
Contributor

Noticed you're using a different indentation than the rest of the project. It should be 2 spaces indentation project-wide. Everyone should be set up with the same prettier formatting settings, but maybe that wasn't set up properly?

@grong0
Copy link
Contributor Author

grong0 commented Nov 11, 2024

Yeah I noticed that too, lemme look into it.

@rtyocum
Copy link
Contributor

rtyocum commented Nov 11, 2024

There is no prettier config file in the repo at all. Without this prettier uses the user's default settings. If you want the consistency then someone needs to add the config file, otherwise you can expect the styles not to match as it's not documented anywhere (at least I couldn't find it)

@grong0
Copy link
Contributor Author

grong0 commented Nov 11, 2024

Yeah, I just added one on my end.
@2nPlusOne is there a doc somewhere that mentions the specific code format? I didn't see a coding format mentioned on the Onboarding Guide or any Contribution section. Might've just missed it though.

@2nPlusOne
Copy link
Contributor

2nPlusOne commented Nov 11, 2024

Yeah, I just added one on my end. @2nPlusOne is there a doc somewhere that mentions the specific code format? I didn't see a coding format mentioned on the Onboarding Guide or any Contribution section. Might've just missed it though.

Not your fault! You're absolutely right, there isn't one. This is definitely something we should fix. I created a ticket for this. Feel free to edit it or drop comments as needed (either of you) with your additional thoughts. Conversation is the beating heart of collaboration.

@grong0
Copy link
Contributor Author

grong0 commented Nov 11, 2024

Thanks!

@PokeJofeJr4th PokeJofeJr4th merged commit 3eec1a2 into main Nov 22, 2024
1 check passed
@PokeJofeJr4th PokeJofeJr4th deleted the dev/projects-api branch November 22, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Story: Projects API Routes
4 participants