Add default end date to memberships #314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavrielrh
force-pushed
the
devlop
branch
2 times, most recently
from
944382b to
b211fef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pre-fills the end date when adding a membership to a (hopefully) sane default.
From what I've seen in the past, memberships typically carry over to the first withdrawal date of the following semester.
This means if I get a membership now (spring 2020), the expiration date should be the fall withdrawal date (9/4/2020), and if I get a membership in the fall, the expiration date should be the following spring withdrawal date (1/22/2021).
I'm pretty bad at conceptualizing time, so please double check my logic on this.
It might also be worth implementing a way of being able to either set, or modify a default for this, that way when dates inevitably change and RIT decides to move starting/ending dates, another PR isn't needed.