Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Some Review Comments #24

Merged
merged 10 commits into from
Oct 12, 2024
Merged

Fix Some Review Comments #24

merged 10 commits into from
Oct 12, 2024

Conversation

ripytide
Copy link
Owner

@ripytide ripytide commented Oct 8, 2024

Fixing some of the comments raised in #23

PR is not quite yet finished but I have finished enough work for today and wanted to put my PR up as a draft in case anyone wants to look/comment/work/interact on it.

  • groups now defaults to empty if you have no groups folder
  • added a new hostname_groups_enabled config
  • empty backends are now not outputted from pacdef unmanaged
  • implemented a new pacdef add command with already-in-your-group-files error messages and using toml_edit with a default default.toml group to save having to always pass three required arguments (now just two required and one optional)
  • added a new --include-implicit option to the clean and unmanaged commands and made it only show explicit packages by default

@ripytide ripytide changed the title Fix Review Comments Fix Some Review Comments Oct 8, 2024
@ripytide ripytide mentioned this pull request Oct 8, 2024
@ripytide ripytide marked this pull request as ready for review October 12, 2024 01:05
@ripytide
Copy link
Owner Author

@InnocentZero I am merging this without review since I'd like to ask if anyone from the upstream pacdef project wants to try out this version.

@ripytide ripytide merged commit 2bd5853 into main Oct 12, 2024
1 check passed
@ripytide
Copy link
Owner Author

Feel free to review it anyway though if you want and we can resolve comments in another PR

@ripytide ripytide deleted the nits branch October 12, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant