Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example configs and tests #20

Closed
wants to merge 10 commits into from
Closed

Add example configs and tests #20

wants to merge 10 commits into from

Conversation

ripytide
Copy link
Owner

I had to add some arguments to the cli to facilicate this, --hostname and --config_dir

This was linked to issues Sep 28, 2024
Add a group file and a config file to the repo #12
Closed
Add a test for checking the example group file and config file works. #18
Closed
InnocentZero
InnocentZero reviewed Sep 28, 2024
View reviewed changes
example_group.toml Outdated Show resolved Hide resolved
src/config.rs Show resolved Hide resolved
@ripytide ripytide mentioned this pull request Sep 29, 2024
Merged
@InnocentZero
Copy link
Collaborator

InnocentZero commented Sep 30, 2024 •
edited
Loading

Can you revert commit 2bbe180? I kept an empty rustfmt.toml there so that it doesn't conflict with my .rustfmt.toml in my home dir, and applies the default formatting. Otherwise LGTM.

@ripytide
Copy link
Owner Author

ripytide commented Oct 1, 2024

Sure, I'll do it in the #22 PR so I don't have to maintain both branches and close this one.

@ripytide ripytide closed this Oct 1, 2024
@ripytide ripytide deleted the example-configs branch October 20, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InnocentZero InnocentZero Awaiting requested review from InnocentZero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ripytide @InnocentZero