Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts a bunch of defines to enums #6071

Merged
merged 6 commits into from
Jan 21, 2025

Conversation

Bassoonian
Copy link
Collaborator

@Bassoonian Bassoonian commented Jan 21, 2025

Converts a bunch of define lists to enums and adds the appropriate type handling.

Feature(s) this PR does NOT handle:

The Pokémon Sprite Visualizer seems to at least partially redundantly copy battle scenes. These should be consolidated in the future.

Things to note in the release changelog:

  • Replaced BATTLE_TERRAIN #defines with the BattleTerrain enum
  • Replaced MAP_TYPE #defines with the MapType enum
  • Replaced MAP_BATTLE_SCENE #defines with the MapBattleScene enum
  • Replaced BACK_ANIM #defines with the BackAnim enum
  • Replaced ANIM #defines with the AnimFunctionIDs enum
  • Replaced INGAME_TRADE #defines with the InGameTradeID enum
  • Replaced TRAINER_CLASS #defines with the TRAINER_CLASS enum

Discord contact info

bassoonian

@hedara90 hedara90 added the General Doesn't fit under other labels label Jan 21, 2025
@hedara90
Copy link
Collaborator

hedara90 commented Jan 21, 2025

I think this should have an expanded explanation for the changelog generator.
(otherwise everything is good)

@hedara90 hedara90 added type: cleanup and removed General Doesn't fit under other labels labels Jan 21, 2025
@Bassoonian
Copy link
Collaborator Author

I think this should have an expanded explanation for the changelog generator. (otherwise everything is good)

For clarity, are you hoping to have the new enums listed there?

@hedara90
Copy link
Collaborator

For clarity, are you hoping to have the new enums listed there?

Yes, basically just: "#defines for replaced with enums

@Bassoonian
Copy link
Collaborator Author

Done!

@hedara90 hedara90 merged commit a3ce3a5 into rh-hideout:upcoming Jan 21, 2025
1 check passed
Bassoonian added a commit that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants