Converts a bunch of defines to enums #6071
Merged
+396
−387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts a bunch of define lists to enums and adds the appropriate type handling.
Feature(s) this PR does NOT handle:
The Pokémon Sprite Visualizer seems to at least partially redundantly copy battle scenes. These should be consolidated in the future.
Things to note in the release changelog:
BATTLE_TERRAIN
#defines with theBattleTerrain
enumMAP_TYPE
#defines with theMapType
enumMAP_BATTLE_SCENE
#defines with theMapBattleScene
enumBACK_ANIM
#defines with theBackAnim
enumANIM
#defines with theAnimFunctionIDs
enumINGAME_TRADE
#defines with theInGameTradeID
enumTRAINER_CLASS
#defines with theTRAINER_CLASS
enumDiscord contact info
bassoonian