Trainer Battle Parameter Consolidation

[u8-Salem]

Consolidates almost all global trainer battle parameter into a global struct

Description

Introduces gTrainerBattleParameter a union of type TrainerBattleParameter. the struct holds most relevant parameter.
the trainerbattle macro was changed to always take all parameters and copy them to the struct, instead of taking parameters depending on battle type.

changed TRAINER_BATTLE_SET_TRAINER_A/B to TRAINER_BATTLE_SET_TRAINERS_FOR_MULTI_BATTLE which takes both trainers always. for 2v1 multi battles leave the second trainer als TRAINER_NONE and NULL for the defeat text.

this PR does NOT handle:

this is part of #5938, which I decided to split into smaller prs. this PR does not do anything but consolidate the parameter.

Things to note in the release changelog:

Breaking: raw uses of trainerbattle need to be adjusted to provide all possible parameter. Unused parameter musst be 0 or an alias. already parameterized macros like trainerbattle_single work out of the box.

Discord contact info

u8-Salem

[u8-Salem]

ready for review again

[AlexOn1ine]

is there anything to watch out with this. anything that you suspect might be broken?

[u8-Salem]

is there anything to watch out with this. anything that you suspect might be broken?

id say the less common battle types need some testing for sure. rematches, multi, facility etc.
I tested all of those except ereader and secret base already but some more cant hurt.

also some battles that have scripts running after them to make sure those arent broken.