Add newer generation Heal Bell interactions with Soundproof #4732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failing |
AlexOn1ine
reviewed
Jun 7, 2024
AlexOn1ine
reviewed
Jun 7, 2024
src/battle_ai_util.c
Outdated
Comment on lines
2969
to
2970
| if ((GetMonData(&party[battlerOnField2], MON_DATA_STATUS) != STATUS1_NONE) | ||
| && (GetBattlerAbility(battlerOnField2) != ABILITY_SOUNDPROOF |
There was a problem hiding this comment.
I would make 2 bools for those things since they are checked twice and would make the code a little bit cleaner
You could go even as far as making a bool for the whole soundproof condition or at least part of it.
There was a problem hiding this comment.
Sadly these aren't checked twice, it's a different battler in each case.
AlexOn1ine
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4704
Discord contact info
duke5614