Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for Corrosion, Acrobatics, Hone Claws, Hurricane #4708

Merged
merged 6 commits into from
Jun 20, 2024

Conversation

Pawkkie
Copy link
Collaborator

@Pawkkie Pawkkie commented Jun 3, 2024

Missing tests for Corrosion, Acrobatics, Hone Claws, and Hurricane

Discord contact info

@Pawkkie

test/battle/ability/corrosion.c Outdated Show resolved Hide resolved
test/battle/ability/corrosion.c Outdated Show resolved Hide resolved
test/battle/ability/corrosion.c Show resolved Hide resolved
@AsparagusEduardo
Copy link
Collaborator

Small review to only Corrosion for now. I'll take a look later for the other tests.

@Pawkkie
Copy link
Collaborator Author

Pawkkie commented Jun 4, 2024

First round of feedback done :)

test/battle/ability/corrosion.c Outdated Show resolved Hide resolved
test/battle/ability/corrosion.c Outdated Show resolved Hide resolved
Bassoonian
Bassoonian previously approved these changes Jun 5, 2024
Copy link
Collaborator

@AsparagusEduardo AsparagusEduardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of things left to address. Everything else lgtm :)

test/battle/move_effect/acrobatics.c Outdated Show resolved Hide resolved
test/battle/move_effect/attack_accuracy_up.c Show resolved Hide resolved
Copy link
Collaborator

@AlexOn1ine AlexOn1ine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple things but looks good otherwise

test/battle/ability/corrosion.c Show resolved Hide resolved
test/battle/ability/corrosion.c Show resolved Hide resolved
test/battle/move_effects_combined/hurricane.c Show resolved Hide resolved
@Pawkkie
Copy link
Collaborator Author

Pawkkie commented Jun 13, 2024

Ready for re-review :)

@Bassoonian Bassoonian merged commit 7ae88d8 into rh-hideout:master Jun 20, 2024
1 check passed
@Pawkkie Pawkkie deleted the assorted-tests branch October 1, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants