Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear Dynamax data when a battler faints #4672

Merged
merged 3 commits into from
May 31, 2024

Conversation

WillKolada
Copy link

Description

Updates FaintClearSetData in battle_main.c to clear Dynamax data when a battler faints.

Issue(s) that this PR fixes

Fixes #4484

Discord contact info

Special K#8400

Now clears dynamax data when a battler faints
Actually call the helper function instead of only doing half of what it does.
@WillKolada
Copy link
Author

In the process of implementing this fix, I discovered a new bug that this does not address (for some reason). The incoming Pokemon does not take the HP penalty from "un-Dynamaxing" anymore, but the Pokemon that faints retains its Dynamax Max HP boost despite no longer being Dynamaxed. This is reverted upon battle end, thankfully, but it means that if you revive this fainted Pokemon, it'll have double the Max HP. I'll look into this more later, but I'll confess it's a far less glaring issue for my own hack than the HP penalty bug is.

@AlexOn1ine
Copy link
Collaborator

In the process of implementing this fix, I discovered a new bug that this does not address (for some reason). The incoming Pokemon does not take the HP penalty from "un-Dynamaxing" anymore, but the Pokemon that faints retains its Dynamax Max HP boost despite no longer being Dynamaxed. This is reverted upon battle end, thankfully, but it means that if you revive this fainted Pokemon, it'll have double the Max HP. I'll look into this more later, but I'll confess it's a far less glaring issue for my own hack than the HP penalty bug is.

Is this a bug that appeared after you added the current fix in this PR?

src/battle_main.c Outdated Show resolved Hide resolved
@WillKolada
Copy link
Author

Is this a bug that appeared after you added the current fix in this PR?

I double-checked to be sure, and no, this bug already existed, I just hadn't noticed it until testing this fix.

@AlexOn1ine AlexOn1ine merged commit 5405e65 into rh-hideout:upcoming May 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants