Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure primary keys are in correct order #19

Merged
merged 1 commit into from
Mar 7, 2024
Merged

fix: ensure primary keys are in correct order #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: MsBackendSql
Title: SQL-based Mass Spectrometry Data Backend
Version: 1.3.3
Version: 1.3.4
Authors@R:
c(person(given = "Johannes", family = "Rainer",
email = "[email protected]",
Expand Down
5 changes: 5 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# MsBackendSql 1.3

## Changes in 1.3.4

- Ensure primary keys from the database are in the correct order for
`backendInitialize()`.

## Changes in 1.3.3

- Import method generics from `ProtGenerics`.
Expand Down
3 changes: 2 additions & 1 deletion R/MsBackendSql.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,8 @@ setMethod("backendInitialize", "MsBackendSql",
if (length(msg)) stop(msg)
object@dbcon <- dbcon
object@spectraIds <- dbGetQuery(
dbcon, "select spectrum_id_ from msms_spectrum")[, 1L]
dbcon, paste0("select spectrum_id_ from msms_spectrum ",
"order by spectrum_id_"))[, 1L]
[email protected] <- list(
msms_spectrum = colnames(
dbGetQuery(dbcon, "select * from msms_spectrum limit 0")))
Expand Down
Loading