Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate adding the source to MacOS and Linux #414

Closed
wants to merge 1 commit into from

Conversation

omarelweshy
Copy link

The command not working on Linux because of brew

The command not working on Linux because of brew
@reubenmiller
Copy link
Owner

@omarelweshy Thanks for taking the time to create a PR.

A few months back I added a command called (c8y cli install and c8y cli profile) which will make things easier for users and document writers...I just held back on documenting it as I wanted to use it long term before I direct other users to use it.

The idea is that the user can either install the required line to all available shells using the following command:

c8y cli install

Or only install the profile for a given shell:

c8y cli install --shell zsh

The good thing is that this will be the same command regardless if people are using Windows, Linux or MacOS.

@omarelweshy What do you think about it?

@reubenmiller
Copy link
Owner

reubenmiller commented Nov 4, 2024

@omarelweshy Though I just noticed that you are following the "homebrew" MacOS instructions...so you shouldn't be following those instructions anyway if you're using Linux...but I do think the instructions could be more clear so that the user only sees the section that they are interested in.

@reubenmiller
Copy link
Owner

@omarelweshy I've created a new PR with the proposed changes. #415

@omarelweshy
Copy link
Author

Hi @reubenmiller The new changes are clean and straightforward.
Thanks for your consideration.

@omarelweshy omarelweshy closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants