Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix handling of encrypted sessions #395

Merged
merged 6 commits into from
Jun 15, 2024
Merged

fix: fix handling of encrypted sessions #395

merged 6 commits into from
Jun 15, 2024

Conversation

reubenmiller
Copy link
Owner

@reubenmiller reubenmiller commented Jun 15, 2024 •
edited
Loading

Fix various problems when dealing with an encrypted session as seen in #392

  • Allow tab completion to still function even a session is not configured or if a session is set but not decrypted
  • Don't fail if encrypted credentials are detected on client setup, as this prevents the set-session from being able to prompt the user for their encryption passphrase

@reubenmiller
clear invalid tokens
411da2b
@reubenmiller
improve logging of session errors
ab86b03
@reubenmiller
prevent panic when client is not set
3085c1e
@reubenmiller
disable encryption check when setting session
2205f3e
@reubenmiller
remove unused assignment
1387fe2
@reubenmiller
don't fail on client setup
f2f1b87 
Client setup should not fail on errors such as decryption problems, as this prevents features such as tab completion from working if a session is not set (or decrypted)
@reubenmiller reubenmiller merged commit 418bb13 into v2 Jun 15, 2024
8 checks passed
@reubenmiller reubenmiller deleted the fix-session-decrypt-error branch June 15, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@reubenmiller