Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter entities in the UI (part 2): Introduce entity filtering in the time panel #8654

Open
wants to merge 7 commits into
base: antoine/filt1-filter-widget
Choose a base branch
from

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Jan 10, 2025

Related

What

This PR introduces the filter widget to the time panel. In doing so, it deals with several shenanigans:

  • The item collapsedness must not be shared between the unfiltered view, and across different filtering sessions
    Note: the collapsed state being persisted, we are now accumulating collapsedness state for every single filter session in the persistant storage. This is not ideal, but addressing that would required rolling our own collapsed state, which would leak all over the place (list item and many of its users).
  • The collapse/expend all context menu must be made aware of what precedes.
  • The time panel filter state must be invalidated upon switching active recording (otherwise it's weird UX).
  • The streams tree UI area needs to have a minimum width otherwise search icon placement/layout breaks.

And of course the actual filtering logic must be implement. For now, the semantics are: "one of the entity part must contain the query string in its entirety". This is very (too) basic and will evolve in future PR (see #8586 (comment)).

streams_tree_filter.mp4

Next step

Major next steps:

  • have filters in more places (primarily blueprint tree)
  • make the filter semantics more useful

@abey79 abey79 added ui concerns graphical user interface do-not-merge Do not merge this PR include in changelog labels Jan 10, 2025
Copy link

github-actions bot commented Jan 10, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
5553c9a https://rerun.io/viewer/pr/8654 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf Wumpf self-requested a review January 10, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Do not merge this PR include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant