EPMRPP-88972 || Fix must condition in the case when previous_launch_i… #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d was not provided
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rc/5.11.0 #160 +/- ##
=============================================
- Coverage 72.59% 72.58% -0.01%
=============================================
Files 39 39
Lines 4955 4954 -1
=============================================
- Hits 3597 3596 -1
Misses 1358 1358
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
HardNorth
requested changes
Jan 8, 2024
| @@ -68,7 +68,7 @@ def _add_launch_name_and_id_boost(self, query: dict, launch_name: str, launch_id | |||
| self._add_launch_name_boost(query, launch_name) | |||
|
|
|||
| def add_constraints_for_launches_into_query(self, query: dict, launch) -> dict: | |||
| previous_launch_id = getattr(launch, 'previousLaunchId', 0) or 0 | |||
| previous_launch_id = getattr(launch, 'previousLaunchId', -1) or -1 | |||
| @@ -39,7 +39,7 @@ | |||
| (2, 'CURRENT_AND_THE_SAME_NAME', DEFAULT_LAUNCH_NAME_SEARCH), | |||
| (2, 'CURRENT_LAUNCH', {'must': [{'term': {'launch_id': DEFAULT_LAUNCH_ID}}]}), | |||
| (2, 'PREVIOUS_LAUNCH', {'must': [{'term': {'launch_id': 2}}]}), | |||
| (None, 'PREVIOUS_LAUNCH', {}), | |||
| (None, 'PREVIOUS_LAUNCH', {'must': [{'term': {'launch_id': -1}}]}), | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d was not provided