Skip to content

Drop messages on the client for closed streams/subscriptions #549

Drop messages on the client for closed streams/subscriptions

Drop messages on the client for closed streams/subscriptions #549

Triggered via pull request January 8, 2025 20:12
Status Success
Total duration 14s
Artifacts

release-drafter.yml

on: pull_request
update_release_draft
6s
update_release_draft
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 1 warning
update_release_draft
Validation Failed: {"resource":"Release","code":"invalid","field":"target_commitish"} { name: 'HttpError', id: '12678249881', status: 422, response: { url: 'https://api.github.com/repos/replit/river-python/releases/193777368', status: 422, headers: { 'access-control-allow-origin': '*', 'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset', connection: 'close', 'content-length': '210', 'content-security-policy': "default-src 'none'", 'content-type': 'application/json; charset=utf-8', date: 'Wed, 08 Jan 2025 20:12:15 GMT', 'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin', server: 'github.com', 'strict-transport-security': 'max-age=31536000; includeSubdomains; preload', vary: 'Accept-Encoding, Accept, X-Requested-With', 'x-accepted-github-permissions': 'contents=write', 'x-content-type-options': 'nosniff', 'x-frame-options': 'deny', 'x-github-api-version-selected': '2022-11-28', 'x-github-media-type': 'github.v3; format=json', 'x-github-request-id': '7006:15D268:FBE3AB:FFFC12:677EDC1F', 'x-ratelimit-limit': '15000', 'x-ratelimit-remaining': '14940', 'x-ratelimit-reset': '1736370283', 'x-ratelimit-resource': 'core', 'x-ratelimit-used': '60', 'x-xss-protection': '0' }, data: { message: 'Validation Failed', errors: [ { resource: 'Release', code: 'invalid', field: 'target_commitish' } ], documentation_url: 'https://docs.github.com/rest/releases/releases#update-a-release', status: '422' } }, request: { method: 'PATCH', url: 'https://api.github.com/repos/replit/river-python/releases/193777368', headers: { accept: 'application/vnd.github.v3+json', 'user-agent': 'probot/12.2.5 octokit-core.js/3.5.1 Node.js/20.18.0 (linux; x64)', authorization: 'token [REDACTED]', 'content-type': 'application/json; charset=utf-8' }, body: '{"body":"## Changes\\n\\n* No changes\\n","draft":true,"prerelease":false,"make_latest":"true","name":"v0.14.1","tag_name":"v0.14.1","target_commitish":"refs/pull/133/merge"}', request: {} }, event: { id: '12678249881', name: 'pull_request', payload: { action: 'synchronize', after: '4537d336751f82c83cb343b1e895368d8e2d7d3c', before: 'b963ede5e47d49f9c150950f36a0c4b79740bbaa', enterprise: { avatar_url: 'https://avatars.githubusercontent.com/b/125249?v=4', created_at: '2024-02-16T01:02:54Z', description: null, html_url: 'https://github.com/enterprises/replit', id: 125249, name: 'Replit', node_id: 'E_kgDOAAHpQQ', slug: 'replit', updated_at: '2024-02-16T01:21:11Z', website_url: null }, number: 133, organization: { avatar_url: 'https://avatars.githubusercontent.com/u/983194?v=4', description: 'Instantly code and collaborate from anywhere', events_url: 'https://api.github.com/orgs/replit/events', hooks_url: 'https://api.github.com/orgs/replit/hooks', id: 983194, issues_url: 'https://api.github.com/orgs/replit/issues', login: 'replit', members_url: 'https://api.github.com/orgs/replit/members{/member}', node_id: 'MDEyOk9yZ2FuaXphdGlvbjk4MzE5NA==', public_members_url: 'https://api.github.com/orgs/replit/public_members{/member}', repos_url: 'https://api.github.com/orgs/replit/repos', url: 'https://api.github.com/orgs/replit' }, pull_request: { _links: { comments: { href: 'https://api.github.com/repos/replit/river-python/issues/133/comments' }, commits:
update_release_draft
HttpError: Validation Failed: {"resource":"Release","code":"invalid","field":"target_commitish"} at /home/runner/work/_actions/release-drafter/release-drafter/v5/dist/index.js:8462:21 at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async Job.doExecute (/home/runner/work/_actions/release-drafter/release-drafter/v5/dist/index.js:30793:18) { name: 'AggregateError', event: { id: '12678249881', name: 'pull_request', payload: { action: 'synchronize', after: '4537d336751f82c83cb343b1e895368d8e2d7d3c', before: 'b963ede5e47d49f9c150950f36a0c4b79740bbaa', enterprise: { avatar_url: 'https://avatars.githubusercontent.com/b/125249?v=4', created_at: '2024-02-16T01:02:54Z', description: null, html_url: 'https://github.com/enterprises/replit', id: 125249, name: 'Replit', node_id: 'E_kgDOAAHpQQ', slug: 'replit', updated_at: '2024-02-16T01:21:11Z', website_url: null }, number: 133, organization: { avatar_url: 'https://avatars.githubusercontent.com/u/983194?v=4', description: 'Instantly code and collaborate from anywhere', events_url: 'https://api.github.com/orgs/replit/events', hooks_url: 'https://api.github.com/orgs/replit/hooks', id: 983194, issues_url: 'https://api.github.com/orgs/replit/issues', login: 'replit', members_url: 'https://api.github.com/orgs/replit/members{/member}', node_id: 'MDEyOk9yZ2FuaXphdGlvbjk4MzE5NA==', public_members_url: 'https://api.github.com/orgs/replit/public_members{/member}', repos_url: 'https://api.github.com/orgs/replit/repos', url: 'https://api.github.com/orgs/replit' }, pull_request: { _links: { comments: { href: 'https://api.github.com/repos/replit/river-python/issues/133/comments' }, commits: { href: 'https://api.github.com/repos/replit/river-python/pulls/133/commits' }, html: { href: 'https://github.com/replit/river-python/pull/133' }, issue: { href: 'https://api.github.com/repos/replit/river-python/issues/133' }, review_comment: { href: 'https://api.github.com/repos/replit/river-python/pulls/comments{/number}' }, review_comments: { href: 'https://api.github.com/repos/replit/river-python/pulls/133/comments' }, self: { href: 'https://api.github.com/repos/replit/river-python/pulls/133' }, statuses: { href: 'https://api.github.com/repos/replit/river-python/statuses/4537d336751f82c83cb343b1e895368d8e2d7d3c' } }, active_lock_reason: null, additions: 70, assignee: null, assignees: [], author_association: 'MEMBER', auto_merge: { commit_message: 'Why\r\n' + '===\r\n' + '\r\n' + 'Each stream/subscription has a messages channel with a capacity of 128\r\n' + 'messages. In our main receive loop, we push messages into the channel,\r\n' + 'blocking until the channel has room. This adds some backpressure, but\r\n' + 'becomes problematic if the stream is not making any progress. For\r\n' + 'example, the client could start a stream and then decide to cancel it\r\n' + 'and not read any of the messages. If the server sends >128 messages, it\r\n' + "will fill up the stream's channel leading to a deadlock for the session.\r\n" + '\r\n' + 'This will be more correctly fixed when river v2 support is landed, as\r\n' + 'that adds support for proper cancellation. In the meantime, we can close\r\n' + 'the channel when we know we are not going to be reading from it anymore,\r\n' + 'and then drop any messages destiined for a closed channel.\r\n' + '\r\n'
update_release_draft
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636