Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uv] uv bleeding edge #422

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Conversation

blast-hardcheese
Copy link
Contributor

@blast-hardcheese blast-hardcheese commented Dec 21, 2024

Why

Bumping uv to latest HEAD in order to get astral-sh/uv#10046, and open us up to just building the latest tags irrespective of what nixpkgs-unstable is tracking.

What changed

Test plan

Verified that the following builds: ✅

$ nix build --no-eval-cache .#'"python-3.12"' -o result.json

Verify that transitively depending on torch successfully resolves: ✅

See the "complete example" in https://docs.astral.sh/uv/guides/integration/pytorch/#using-a-pytorch-index

Rollout

Describe any procedures or requirements needed to roll this out safely (or check the box below)

  • This is fully backward and forward compatible

@blast-hardcheese blast-hardcheese requested a review from a team as a code owner December 21, 2024 01:00
@blast-hardcheese blast-hardcheese requested review from ryantm and removed request for a team December 21, 2024 01:00
@blast-hardcheese blast-hardcheese force-pushed the dstewart/chore/uv-bleeding-edge branch from 0d2d871 to cddc6fd Compare December 21, 2024 01:07
Copy link

@rmehri01 rmehri01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is there a compelling reason to go so bleeding edge?


rustPlatform.buildRustPackage rec {
pname = "uv";
version = "0.5.11"; # Technically 8 versions ahead of 0.5.11
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the story here?

@blast-hardcheese
Copy link
Contributor Author

@ryantm there's a bugfix merged today that solves an issue with our users' ability to install pytorch. It's still being iterated on by the uv team, but at least now we're in a place to have more control of when new versions drop more broadly.

@blast-hardcheese blast-hardcheese merged commit 838cf4b into main Dec 23, 2024
3 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/chore/uv-bleeding-edge branch December 23, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants