Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure version number gets updated without having to run dune clean #866

Open
wants to merge 1 commit into
base: sail2
Choose a base branch
from

Conversation

Alasdair
Copy link
Collaborator

@Alasdair Alasdair commented Jan 8, 2025

Adds (deps (universe)) to the action that builds manifest.ml so it is always rebuilt (unless it was generated from manifest.ml.in by opam, as the action still has fallback mode).

Fixes #204, and based on PR #863

Adds (deps (universe)) to the action that builds manifest.ml so it is
always rebuilt (unless it was generated from manifest.ml.in by opam, as
the action still has fallback mode).

Fixes #204, and based on PR #863
@Alasdair
Copy link
Collaborator Author

Alasdair commented Jan 8, 2025

Tested by making a dummy commit, and using git checkout between that commit and HEAD~1 followed by make install causes the hash in sail --version to update immediately.

For the opam install functionality opam config subst src/bin/manifest.ml followed by dune build --release --verbose shows that the sail_manifest binary is not run as expected, and sail --version shows the opam version number.

Copy link

github-actions bot commented Jan 8, 2025

Test Results

   12 files  ±0     24 suites  ±0   0s ⏱️ ±0s
  741 tests ±0    741 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 476 runs  ±0  2 476 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 35bfd4f. ± Comparison against base commit 18b0aec.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print git hash in version output and add -version
1 participant