Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CN] Add CI for CN runtime testing capability #458

Merged
merged 6 commits into from
Aug 8, 2024

Conversation

septract
Copy link
Collaborator

@septract septract commented Aug 1, 2024

Runs the CN runtime testing capability over specially-modified examples from the CN tutorial.

Note:

  • The CI script checks out branch CN-exec: Upgrade single file runtime test script #439, which includes necessary test script modifications. Before merging this branch, we need to merge CN-exec: Upgrade single file runtime test script #439 and then the checkout target should be changed to cerberus:master
  • The CI script applies the runtime testing to cn-tutorial:cn-runtime-testing. This branch adds main() functions to the tutorial examples, and so it cannot be merged into cn-tutorial:main. It's okay to merge without resolving this, but we should fix it sooner rather than later.

@septract
Copy link
Collaborator Author

septract commented Aug 1, 2024

@rbanerjee20

@septract septract changed the title Add CI for CN runtime testing capability [CN] Add CI for CN runtime testing capability Aug 1, 2024
@septract septract marked this pull request as ready for review August 1, 2024 23:45
@rbanerjee20
Copy link
Contributor

I've approved #439 now so once that is merged I'm happy to approve and merge this PR too.

@septract
Copy link
Collaborator Author

septract commented Aug 8, 2024

@rbanerjee20 Looks like this is working! If you're happy with the PR, go ahead and merge.

@septract
Copy link
Collaborator Author

septract commented Aug 8, 2024

Note this PR still points to a branch on cn-tutorial - see here: rems-project/cn-tutorial#70

Okay to merge as is, but we should fix this at some point soon.

@dc-mak

@rbanerjee20 rbanerjee20 merged commit 2702dba into rems-project:master Aug 8, 2024
2 checks passed
@septract septract deleted the mdd/ci-runtime-check branch August 12, 2024 17:57
dc-mak added a commit that referenced this pull request Aug 14, 2024
Commit 3adb12e meant to set the Docker builds to run daily but the syntax was off by one colon. This commit fixes this.
@dc-mak
Copy link
Contributor

dc-mak commented Aug 14, 2024

Just for posterity, 8722102 has the wrong issue number, it should be #489 but I got it wrong in a rush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants