Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow avoiding inclusion of other permissions #141

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

hluk
Copy link
Member

@hluk hluk commented Nov 21, 2023

Permission mapping items can have optional field "testcases_ignore" with
list of patterns to avoid matching specific test case names.

JIRA: RHELWF-10228

@hluk hluk requested a review from mvalik November 21, 2023 12:08
@hluk hluk marked this pull request as draft November 23, 2023 10:54
@hluk hluk force-pushed the permission-include-following branch 2 times, most recently from 1920afc to 84e3416 Compare November 28, 2023 07:19
@hluk hluk marked this pull request as ready for review November 29, 2023 06:38
@hluk
Copy link
Member Author

hluk commented Nov 29, 2023

@mvalik Please review. This may be needed this week.

@hluk
Copy link
Member Author

hluk commented Nov 29, 2023

This is what the permissions page looks like:
image

Copy link
Contributor

@mvalik mvalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small notes, otherwise ok

waiverdb/templates/permissions.html Outdated Show resolved Hide resolved
waiverdb/templates/permissions.html Outdated Show resolved Hide resolved
Permission mapping items can have optional field "testcases_ignore" with
list of patterns to avoid matching specific test case names that are
otherwise matched by "testcases".

JIRA: RHELWF-10228
@hluk hluk force-pushed the permission-include-following branch from 84e3416 to 397135b Compare November 30, 2023 05:52
@hluk hluk merged commit cb409df into release-engineering:master Nov 30, 2023
6 checks passed
@hluk hluk deleted the permission-include-following branch December 5, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants