Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump werkzeug from 2.3.7 to 2.3.8 #135

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 14, 2023

Bumps werkzeug from 2.3.7 to 2.3.8.

Release notes

Sourced from werkzeug's releases.

2.3.8

This is a security release for the 2.3.x feature branch.

Changelog

Sourced from werkzeug's changelog.

Version 2.3.8

Released 2023-11-08

  • Fix slow multipart parsing for large parts potentially enabling DoS attacks. :cwe:CWE-407
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [werkzeug](https://github.com/pallets/werkzeug) from 2.3.7 to 2.3.8.
- [Release notes](https://github.com/pallets/werkzeug/releases)
- [Changelog](https://github.com/pallets/werkzeug/blob/main/CHANGES.rst)
- [Commits](pallets/werkzeug@2.3.7...2.3.8)

---
updated-dependencies:
- dependency-name: werkzeug
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 14, 2023
@hluk
Copy link
Member

hluk commented Nov 14, 2023

Perfect! We may be able to move soon to new werkzeug 3 - after fix for flask-session is released: pallets-eco/flask-session#189

@hluk hluk merged commit d0c163b into master Nov 14, 2023
12 checks passed
@dependabot dependabot bot deleted the dependabot/pip/werkzeug-2.3.8 branch November 14, 2023 11:21
@hluk
Copy link
Member

hluk commented Nov 20, 2023

Unfortunately, this seems to break compatibility with flask-session too. Need to revert this.

hluk added a commit to hluk/waiverdb that referenced this pull request Nov 20, 2023
This reverts commit d0c163b.

This seems to break compatibility with flask-session too. It causes the
following exception:

    [2023-11-20 09:31:15 +0000] [9] [ERROR] Error handling request /healthcheck
    Traceback (most recent call last):
      File "/venv/lib64/python3.11/site-packages/gunicorn/workers/gthread.py", line 282, in handle
        keepalive = self.handle_request(req, conn)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/venv/lib64/python3.11/site-packages/gunicorn/workers/gthread.py", line 334, in handle_request
        respiter = self.wsgi(environ, resp.start_response)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/venv/lib64/python3.11/site-packages/flask/app.py", line 2552, in __call__
        return self.wsgi_app(environ, start_response)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/venv/lib64/python3.11/site-packages/flask/app.py", line 2532, in wsgi_app
        response = self.handle_exception(e)
                   ^^^^^^^^^^^^^^^^^^^^^^^^
      File "/venv/lib64/python3.11/site-packages/flask_cors/extension.py", line 176, in wrapped_function
        return cors_after_request(app.make_response(f(*args, **kwargs)))
                                                    ^^^^^^^^^^^^^^^^^^
      File "/venv/lib64/python3.11/site-packages/flask_restx/api.py", line 674, in error_router
        return original_handler(e)
               ^^^^^^^^^^^^^^^^^^^
      File "/venv/lib64/python3.11/site-packages/flask/app.py", line 2529, in wsgi_app
        response = self.full_dispatch_request()
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/venv/lib64/python3.11/site-packages/flask/app.py", line 1826, in full_dispatch_request
        return self.finalize_request(rv)
               ^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/venv/lib64/python3.11/site-packages/flask/app.py", line 1847, in finalize_request
        response = self.process_response(response)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/venv/lib64/python3.11/site-packages/flask/app.py", line 2344, in process_response
        self.session_interface.save_session(self, ctx.session, response)
      File "/venv/lib64/python3.11/site-packages/flask_session/sessions.py", line 573, in save_session
        response.set_cookie(app.config["SESSION_COOKIE_NAME"], session_id,
      File "/venv/lib64/python3.11/site-packages/werkzeug/sansio/response.py", line 224, in set_cookie
        dump_cookie(
      File "/venv/lib64/python3.11/site-packages/werkzeug/http.py", line 1303, in dump_cookie
        if not _cookie_no_quote_re.fullmatch(value):
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    TypeError: cannot use a string pattern on a bytes-like object
@hluk
Copy link
Member

hluk commented Nov 20, 2023

Unfortunately, this seems to break compatibility with flask-session too. Need to revert this.

Never mind this is probably caused by an old image in dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant