Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #229

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

hluk
Copy link
Member

@hluk hluk commented Jan 11, 2024

Send clear error message to client if an external service request fails and log the error.

Simplifies mocking network requests with requests-mock library.

JIRA: RHELWF-10400

@hluk hluk force-pushed the improve-error-handling branch from c2f4e62 to c4829d0 Compare January 11, 2024 09:21
@hluk hluk requested a review from mvalik January 11, 2024 10:37
Send clear error message to client if an external service request fails
and log the error.

Simplifies mocking network requests with requests-mock library.

JIRA: RHELWF-10400
@hluk hluk force-pushed the improve-error-handling branch from c4829d0 to 16b4419 Compare January 12, 2024 10:52
Copy link
Contributor

@mvalik mvalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hluk hluk merged commit 16d88ef into release-engineering:master Jan 17, 2024
11 checks passed
@hluk hluk deleted the improve-error-handling branch January 18, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants