Remove stubs #51
Merged
Remove stubs #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Legacy:) thank you |
|
Cool. Could you create a release? The stubs existance makes some apps of mine mixing up the classes - because of ugly autoloading rules on my end :-) |
|
They should never be part of release. |
|
yeah, but they are contained in the current 2.0.0 release. see https://github.com/FriendsOfREDAXO/rexstan/tree/main/vendor/rector/type-perfect btw: the release also contains a phpstan-for-tests.neon in the project root |
|
Yea, that should not happen 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wonder why we need these stubs?
it seems they are not referenced anywhere.. and tests don't fail if we delete them?