Consider config for NarrowReturnObjectTypeRule #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Jun 17, 2024
|
as a run of the code style fixer fixed some unrelated files, I would assume, that https://github.com/rectorphp/type-perfect/blob/main/.github/workflows/code_analysis.yaml#L29 is not set up correctly 🤔 should this be |
mitelg
force-pushed
the
fix/consider-config
branch
from
7a24a2e to
06748a7
Compare
|
I adjusted the job, because it should have failed for example on this run https://github.com/rectorphp/type-perfect/actions/runs/9547786462/job/26313537179 |
samsonasik
approved these changes
Jun 17, 2024
|
Thank you @mitelg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #12