Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for processing junit4 reports from TEST-junit-vintage.xml #134

Merged
merged 2 commits into from
Aug 24, 2024
Merged

Add support for processing junit4 reports from TEST-junit-vintage.xml #134

merged 2 commits into from
Aug 24, 2024

Conversation

stefanwatt
Copy link
Contributor

@stefanwatt stefanwatt commented Aug 18, 2024 •
edited
Loading

Content:

  • spec_builder now just returns the reports_dir instead of a path to a file
  • result_builder now builds results for all the possible report files

@stefanwatt stefanwatt force-pushed the bugfix/org-junit-test-reports branch 2 times, most recently from 9502b68 to 61ec148 Compare August 18, 2024 16:58
- spec_builder now just returns the reports_dir instead of a path to …
cc6b7c8 
…a file

- result_builder now builds results for all the possible report files
@stefanwatt stefanwatt force-pushed the bugfix/org-junit-test-reports branch from 61ec148 to cc6b7c8 Compare August 18, 2024 16:58
@rcasia rcasia linked an issue Aug 18, 2024 that may be closed by this pull request
"This test was not executed" when using org.junit.Test import #133
Closed
@stefanwatt
Copy link
Contributor Author

stefanwatt commented Aug 18, 2024 •
edited
Loading

To be honest I don't know how to run the lua tests locally.
Should it "just work" with neotest?

@rcasia
feat: takes all the tests in a directory
4156487 
- adecuate tests to new implementation
- takes all report files in a directory
@rcasia
Copy link
Owner

rcasia commented Aug 24, 2024

The approach was correct. I just made some adjusments:

  • fixed the formatting
  • read all the files in the report_dir so if the name changes it still reads it.

Thanks for all and sorry for my late response!

@rcasia rcasia merged commit d624c32 into rcasia:main Aug 24, 2024
3 checks passed
@stefanwatt stefanwatt deleted the bugfix/org-junit-test-reports branch September 17, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"This test was not executed" when using org.junit.Test import
2 participants
@stefanwatt @rcasia