Address various warnings new in clang-tidy 19 #4548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randombit
force-pushed
the
jack/clang-tidy-19-fixes
branch
from
571a5f8 to
f24d5af
Compare
randombit
force-pushed
the
jack/clang-tidy-19-fixes
branch
3 times, most recently
from
d8f0359 to
12c19fb
Compare
reneme
approved these changes
Jan 17, 2025
| -misc-redundant-expression, | ||
| -misc-misplaced-const, | ||
| -misc-confusable-identifiers, | ||
| -modernize-avoid-bind, | ||
| -modernize-pass-by-value, | ||
| -modernize-use-ranges, |
There was a problem hiding this comment.
We might want to enable and act on that as soon as we have the compilers for it. Perhaps leave a TODO(Botan4) or something? Edit: oh, right. I found the comment in the other list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.