Consistently use ClassicMcEliece for CMCE parameter names #4508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneme
reviewed
Dec 30, 2024
FAlbertDev
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
I see your point. My main concern with this change is that the parameter names do not match with the specification (see NIST Round 4 Spec (chapter 7) and ISO draft (chapter 10)). But I agree that the inconsistency is quite confusing. I'm fine with both variants 👍
randombit
force-pushed
the
jack/bike-shed-cmce-params
branch
2 times, most recently
from
0e4527f to
1873d51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we have some places where we have to string match on "mceliece" from the OIDs while others we use "ClassicMcEliece"
Kind of a minor thing but it seems easy to fix (right now, before any of this is in a release)