render v3 spoils in spoils table #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ECWireless
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Awesome to see this all working! I just left a tiny comment. Also, and this is going to sound like a huge nitpick, but could we change the useFormattedData hook files names to be useFormattedAccounting (with the v2 and v3 ending)? Calling it a "formatted data" hook just seems way to broad for what it's actually doing
ECWireless
approved these changes
Jul 26, 2024
ECWireless
merged commit 63e8950
into
feat/upgrade-accounting-page-for-moloch-v3
2 checks passed
ECWireless
added a commit
that referenced
this pull request
Jul 29, 2024
* Add v2 and v3 panels for each tab (#131) Co-authored-by: growindiedev <[email protected]> * PR for #132 (#138) * organise memos in one hook * split useAccounting into useAccountingV2 & useAccountingV3 * Remove useAccounting hook --------- Co-authored-by: ECWireless <[email protected]> * needs clean up * cleaned up useAccountingV3 * [WIP] Accounting Fixes + Transaction Data (#141) * fix issue * fetch tx data * proposal data * wip * wip2 * fetch all transactions * use bigint for calculating sum of in/out flows * transactions * cache results * display member & proposal & proposal link * fix proposals * fix type * cleanup * set balancesWithPricesV3 data for csv export fix * add elapsed days and ragequit shares * add in/out/balance USD * rename * fix types * token symbol value --------- Co-authored-by: vidvidvid <[email protected]> * render v3 spoils in spoils table (#148) * remove V2 data from accounting and fixed type and export errors * fetch smartInvoices and add query to fecth raids * create formatSpoils function and raids query mvp * unsuccessful attempt to fetch raids in useAccountingV3 * fetch invoice and raids and map them together using formatSpoils * render formatted spoils in spoilsTable * clean up useAccountingV3 & useFormattedDataV3 * cleanup accounting.tsx * change file names for useFormattedData to useFormattedAccountingV3 * Minor tweaks --------- Co-authored-by: growindiedev <[email protected]> Co-authored-by: Abhishek Ranjan <[email protected]> Co-authored-by: Sero <[email protected]> Co-authored-by: vidvidvid <[email protected]>
ECWireless
added a commit
that referenced
this pull request
Jul 29, 2024
* Add v2 and v3 panels for each tab (#131) * PR for #132 (#138) * organise memos in one hook * split useAccounting into useAccountingV2 & useAccountingV3 * Remove useAccounting hook --------- * needs clean up * cleaned up useAccountingV3 * [WIP] Accounting Fixes + Transaction Data (#141) * fix issue * fetch tx data * proposal data * wip * wip2 * fetch all transactions * use bigint for calculating sum of in/out flows * transactions * cache results * display member & proposal & proposal link * fix proposals * fix type * cleanup * set balancesWithPricesV3 data for csv export fix * add elapsed days and ragequit shares * add in/out/balance USD * rename * fix types * token symbol value --------- * render v3 spoils in spoils table (#148) * remove V2 data from accounting and fixed type and export errors * fetch smartInvoices and add query to fecth raids * create formatSpoils function and raids query mvp * unsuccessful attempt to fetch raids in useAccountingV3 * fetch invoice and raids and map them together using formatSpoils * render formatted spoils in spoilsTable * clean up useAccountingV3 & useFormattedDataV3 * cleanup accounting.tsx * change file names for useFormattedData to useFormattedAccountingV3 * Minor tweaks --------- Co-authored-by: growindiedev <[email protected]> Co-authored-by: Abhishek Ranjan <[email protected]> Co-authored-by: Sero <[email protected]> Co-authored-by: vidvidvid <[email protected]>
ECWireless
added a commit
that referenced
this pull request
Aug 11, 2024
* Upgrade accounting page for moloch v3 (#149) * Add v2 and v3 panels for each tab (#131) Co-authored-by: growindiedev <[email protected]> * PR for #132 (#138) * organise memos in one hook * split useAccounting into useAccountingV2 & useAccountingV3 * Remove useAccounting hook --------- Co-authored-by: ECWireless <[email protected]> * needs clean up * cleaned up useAccountingV3 * [WIP] Accounting Fixes + Transaction Data (#141) * fix issue * fetch tx data * proposal data * wip * wip2 * fetch all transactions * use bigint for calculating sum of in/out flows * transactions * cache results * display member & proposal & proposal link * fix proposals * fix type * cleanup * set balancesWithPricesV3 data for csv export fix * add elapsed days and ragequit shares * add in/out/balance USD * rename * fix types * token symbol value --------- Co-authored-by: vidvidvid <[email protected]> * render v3 spoils in spoils table (#148) * remove V2 data from accounting and fixed type and export errors * fetch smartInvoices and add query to fecth raids * create formatSpoils function and raids query mvp * unsuccessful attempt to fetch raids in useAccountingV3 * fetch invoice and raids and map them together using formatSpoils * render formatted spoils in spoilsTable * clean up useAccountingV3 & useFormattedDataV3 * cleanup accounting.tsx * change file names for useFormattedData to useFormattedAccountingV3 * Minor tweaks --------- Co-authored-by: growindiedev <[email protected]> Co-authored-by: Abhishek Ranjan <[email protected]> Co-authored-by: Sero <[email protected]> Co-authored-by: vidvidvid <[email protected]> * Add invoices table and allow for Optimism chain invoices (#147) * Add invoices table * Remove unused remote schemas * Add Optimism to escrow network config * Prompt user to switch chain if unsupported * Add warnings for Optimism and Mainnet chains * Prevent RIP escrow on Optimism * Ensure that user is always on the right chain * Restrict to native USDC on Optimism * Add insert invoice to Hasura functionality * Add created_at and updated_at columns * Ensure create escrow link allows chain selection * Add chain ID to escrow confirmation * Render chain ID name to raid and escrow pages * Format amounts with correct decimals --------- Co-authored-by: growindiedev <[email protected]> Co-authored-by: Abhishek Ranjan <[email protected]> Co-authored-by: Sero <[email protected]> Co-authored-by: vidvidvid <[email protected]>
ECWireless
added a commit
that referenced
this pull request
Aug 12, 2024
* Upgrade accounting page for moloch v3 (#149) * Add v2 and v3 panels for each tab (#131) Co-authored-by: growindiedev <[email protected]> * PR for #132 (#138) * organise memos in one hook * split useAccounting into useAccountingV2 & useAccountingV3 * Remove useAccounting hook --------- Co-authored-by: ECWireless <[email protected]> * needs clean up * cleaned up useAccountingV3 * [WIP] Accounting Fixes + Transaction Data (#141) * fix issue * fetch tx data * proposal data * wip * wip2 * fetch all transactions * use bigint for calculating sum of in/out flows * transactions * cache results * display member & proposal & proposal link * fix proposals * fix type * cleanup * set balancesWithPricesV3 data for csv export fix * add elapsed days and ragequit shares * add in/out/balance USD * rename * fix types * token symbol value --------- Co-authored-by: vidvidvid <[email protected]> * render v3 spoils in spoils table (#148) * remove V2 data from accounting and fixed type and export errors * fetch smartInvoices and add query to fecth raids * create formatSpoils function and raids query mvp * unsuccessful attempt to fetch raids in useAccountingV3 * fetch invoice and raids and map them together using formatSpoils * render formatted spoils in spoilsTable * clean up useAccountingV3 & useFormattedDataV3 * cleanup accounting.tsx * change file names for useFormattedData to useFormattedAccountingV3 * Minor tweaks --------- Co-authored-by: growindiedev <[email protected]> Co-authored-by: Abhishek Ranjan <[email protected]> Co-authored-by: Sero <[email protected]> Co-authored-by: vidvidvid <[email protected]> * Add invoices table and allow for Optimism chain invoices (#147) * Add invoices table * Remove unused remote schemas * Add Optimism to escrow network config * Prompt user to switch chain if unsupported * Add warnings for Optimism and Mainnet chains * Prevent RIP escrow on Optimism * Ensure that user is always on the right chain * Restrict to native USDC on Optimism * Add insert invoice to Hasura functionality * Add created_at and updated_at columns * Ensure create escrow link allows chain selection * Add chain ID to escrow confirmation * Render chain ID name to raid and escrow pages * Format amounts with correct decimals * Allow member access to invoice table (#152) --------- Co-authored-by: growindiedev <[email protected]> Co-authored-by: Abhishek Ranjan <[email protected]> Co-authored-by: Sero <[email protected]> Co-authored-by: vidvidvid <[email protected]>
ECWireless
added a commit
that referenced
this pull request
Aug 16, 2024
* Upgrade accounting page for moloch v3 (#149) * Add v2 and v3 panels for each tab (#131) Co-authored-by: growindiedev <[email protected]> * PR for #132 (#138) * organise memos in one hook * split useAccounting into useAccountingV2 & useAccountingV3 * Remove useAccounting hook --------- Co-authored-by: ECWireless <[email protected]> * needs clean up * cleaned up useAccountingV3 * [WIP] Accounting Fixes + Transaction Data (#141) * fix issue * fetch tx data * proposal data * wip * wip2 * fetch all transactions * use bigint for calculating sum of in/out flows * transactions * cache results * display member & proposal & proposal link * fix proposals * fix type * cleanup * set balancesWithPricesV3 data for csv export fix * add elapsed days and ragequit shares * add in/out/balance USD * rename * fix types * token symbol value --------- Co-authored-by: vidvidvid <[email protected]> * render v3 spoils in spoils table (#148) * remove V2 data from accounting and fixed type and export errors * fetch smartInvoices and add query to fecth raids * create formatSpoils function and raids query mvp * unsuccessful attempt to fetch raids in useAccountingV3 * fetch invoice and raids and map them together using formatSpoils * render formatted spoils in spoilsTable * clean up useAccountingV3 & useFormattedDataV3 * cleanup accounting.tsx * change file names for useFormattedData to useFormattedAccountingV3 * Minor tweaks --------- Co-authored-by: growindiedev <[email protected]> Co-authored-by: Abhishek Ranjan <[email protected]> Co-authored-by: Sero <[email protected]> Co-authored-by: vidvidvid <[email protected]> * Add invoices table and allow for Optimism chain invoices (#147) * Add invoices table * Remove unused remote schemas * Add Optimism to escrow network config * Prompt user to switch chain if unsupported * Add warnings for Optimism and Mainnet chains * Prevent RIP escrow on Optimism * Ensure that user is always on the right chain * Restrict to native USDC on Optimism * Add insert invoice to Hasura functionality * Add created_at and updated_at columns * Ensure create escrow link allows chain selection * Add chain ID to escrow confirmation * Render chain ID name to raid and escrow pages * Format amounts with correct decimals * Allow member access to invoice table (#152) * Update smart invoice subgraph versions (#154) --------- Co-authored-by: growindiedev <[email protected]> Co-authored-by: Abhishek Ranjan <[email protected]> Co-authored-by: Sero <[email protected]> Co-authored-by: vidvidvid <[email protected]>
ECWireless
added a commit
that referenced
this pull request
Nov 22, 2024
* Upgrade accounting page for moloch v3 (#149) * Add v2 and v3 panels for each tab (#131) Co-authored-by: growindiedev <[email protected]> * PR for #132 (#138) * organise memos in one hook * split useAccounting into useAccountingV2 & useAccountingV3 * Remove useAccounting hook --------- Co-authored-by: ECWireless <[email protected]> * needs clean up * cleaned up useAccountingV3 * [WIP] Accounting Fixes + Transaction Data (#141) * fix issue * fetch tx data * proposal data * wip * wip2 * fetch all transactions * use bigint for calculating sum of in/out flows * transactions * cache results * display member & proposal & proposal link * fix proposals * fix type * cleanup * set balancesWithPricesV3 data for csv export fix * add elapsed days and ragequit shares * add in/out/balance USD * rename * fix types * token symbol value --------- Co-authored-by: vidvidvid <[email protected]> * render v3 spoils in spoils table (#148) * remove V2 data from accounting and fixed type and export errors * fetch smartInvoices and add query to fecth raids * create formatSpoils function and raids query mvp * unsuccessful attempt to fetch raids in useAccountingV3 * fetch invoice and raids and map them together using formatSpoils * render formatted spoils in spoilsTable * clean up useAccountingV3 & useFormattedDataV3 * cleanup accounting.tsx * change file names for useFormattedData to useFormattedAccountingV3 * Minor tweaks --------- Co-authored-by: growindiedev <[email protected]> Co-authored-by: Abhishek Ranjan <[email protected]> Co-authored-by: Sero <[email protected]> Co-authored-by: vidvidvid <[email protected]> * Add invoices table and allow for Optimism chain invoices (#147) * Add invoices table * Remove unused remote schemas * Add Optimism to escrow network config * Prompt user to switch chain if unsupported * Add warnings for Optimism and Mainnet chains * Prevent RIP escrow on Optimism * Ensure that user is always on the right chain * Restrict to native USDC on Optimism * Add insert invoice to Hasura functionality * Add created_at and updated_at columns * Ensure create escrow link allows chain selection * Add chain ID to escrow confirmation * Render chain ID name to raid and escrow pages * Format amounts with correct decimals * Allow member access to invoice table (#152) * Update smart invoice subgraph versions (#154) * fix member reload * fix user card content overflow * set up migration & textarea * display description instead of introduction * reuse Description component * cleanup * Upgrade smart invoice optimism subgraph to v0.0.3 (#161) * Upgrade smart invoice optimism subgraph to v0.0.3 * Update how escrows are fetched in accounting page --------- Co-authored-by: ECWireless <[email protected]> Co-authored-by: growindiedev <[email protected]> Co-authored-by: Abhishek Ranjan <[email protected]> Co-authored-by: Sero <[email protected]> Co-authored-by: ECWireless <[email protected]> Co-authored-by: Sayo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #135