-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move database and similar packages to components #8148
Conversation
dcf0c24
to
dc72a54
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8148 +/- ##
==========================================
- Coverage 59.52% 59.51% -0.01%
==========================================
Files 580 580
Lines 39008 39008
==========================================
- Hits 23219 23216 -3
- Misses 14077 14079 +2
- Partials 1712 1713 +1 ☔ View full report in Codecov by Sentry. |
dc72a54
to
6f2e382
Compare
Working on fixing |
6f2e382
to
bb16bb8
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
bb16bb8
to
bb3dbd0
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
This change moves and rearranges some our packages so they are easy to reference. The new `components` folder is for shared components that are used in all of our code. Previously these components were part of UCP which doesn't make sense, they are used by all of our control-plane services. Signed-off-by: Ryan Nowak <[email protected]>
bb3dbd0
to
b535e57
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Test failure was a 409 conflict upstream in Azure. Unrelated to changes in this PR. I'll try re-running and then investigate if it repros. |
Going to bypass the functional test behavior because this change is a refactor, and this appears to be a transient Azure issue. Let's keep an eye on this, because it will likely fail in other PRs if its not resolved soon. |
Description
This change moves and rearranges some our packages so they are easy to reference. The new
components
folder is for shared components that are used in all of our code. Previously these components were part of UCP which doesn't make sense, they are used by all of our control-plane services.Type of change
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: