Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move database and similar packages to components #8148

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

rynowak
Copy link
Contributor

@rynowak rynowak commented Dec 17, 2024

Description

This change moves and rearranges some our packages so they are easy to reference. The new components folder is for shared components that are used in all of our code. Previously these components were part of UCP which doesn't make sense, they are used by all of our control-plane services.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
  • If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

@rynowak rynowak requested review from a team as code owners December 17, 2024 20:16
bicep-types Outdated Show resolved Hide resolved
pkg/recipes/terraform/execute.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 81.57895% with 7 lines in your changes missing coverage. Please review.

Project coverage is 59.51%. Comparing base (6281a2f) to head (b535e57).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/components/queue/apiserver/client.go 88.88% 1 Missing and 1 partial ⚠️
pkg/recipes/driver/terraform.go 0.00% 1 Missing ⚠️
pkg/recipes/terraform/config/providers/aws.go 0.00% 1 Missing ⚠️
pkg/recipes/terraform/config/providers/azure.go 0.00% 1 Missing ⚠️
pkg/recipes/terraform/config/providers/types.go 0.00% 1 Missing ⚠️
pkg/recipes/terraform/execute.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8148      +/-   ##
==========================================
- Coverage   59.52%   59.51%   -0.01%     
==========================================
  Files         580      580              
  Lines       39008    39008              
==========================================
- Hits        23219    23216       -3     
- Misses      14077    14079       +2     
- Partials     1712     1713       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ytimocin
ytimocin previously approved these changes Dec 17, 2024
@rynowak
Copy link
Contributor Author

rynowak commented Dec 17, 2024

Working on fixing make generate error

@radius-functional-tests
Copy link

radius-functional-tests bot commented Dec 17, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository rynowak/radius
Commit ref bb16bb8
Unique ID func48f1efb904
Image tag pr-func48f1efb904
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func48f1efb904
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func48f1efb904
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func48f1efb904
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func48f1efb904
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func48f1efb904
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@radius-functional-tests
Copy link

radius-functional-tests bot commented Dec 18, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository rynowak/radius
Commit ref bb3dbd0
Unique ID func103a81be54
Image tag pr-func103a81be54
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func103a81be54
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func103a81be54
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func103a81be54
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func103a81be54
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func103a81be54
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
❌ corerp-cloud functional test failed. Please check the logs for more details

This change moves and rearranges some our packages so they are easy to reference. The new `components` folder is for shared components that are used in all of our code. Previously these components were part of UCP which doesn't make sense, they are used by all of our control-plane services.

Signed-off-by: Ryan Nowak <[email protected]>
@rynowak rynowak temporarily deployed to functional-tests December 18, 2024 18:08 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Dec 18, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository rynowak/radius
Commit ref b535e57
Unique ID func551f8a8efc
Image tag pr-func551f8a8efc
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func551f8a8efc
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func551f8a8efc
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func551f8a8efc
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func551f8a8efc
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func551f8a8efc
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
❌ corerp-cloud functional test failed. Please check the logs for more details
⌛ Starting corerp-cloud functional tests...
❌ corerp-cloud functional test failed. Please check the logs for more details

@rynowak
Copy link
Contributor Author

rynowak commented Dec 18, 2024

Test failure was a 409 conflict upstream in Azure. Unrelated to changes in this PR. I'll try re-running and then investigate if it repros.

@rynowak
Copy link
Contributor Author

rynowak commented Dec 18, 2024

Going to bypass the functional test behavior because this change is a refactor, and this appears to be a transient Azure issue. Let's keep an eye on this, because it will likely fail in other PRs if its not resolved soon.

@rynowak rynowak merged commit d87e854 into radius-project:main Dec 18, 2024
28 of 29 checks passed
@rynowak rynowak deleted the database-package-move branch December 18, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants