Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change region to solve s3 issues #8117

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

nithyatsu
Copy link
Contributor

Description

Changing region because of s3 issues with us-west-2

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).
  • This pull request adds or changes features of Radius and has an approved issue (issue link required).
  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
  • If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

@nithyatsu nithyatsu requested review from a team as code owners December 10, 2024 23:44
Copy link
Contributor

@kachawla kachawla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update this in long running tests wf as well

?

@radius-functional-tests
Copy link

radius-functional-tests bot commented Dec 10, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository nithyatsu/radius
Commit ref 318dd5a
Unique ID funcc6b80deaf8
Image tag pr-funcc6b80deaf8
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcc6b80deaf8
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcc6b80deaf8
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcc6b80deaf8
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcc6b80deaf8
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcc6b80deaf8
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.27%. Comparing base (c7ccd82) to head (318dd5a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8117      +/-   ##
==========================================
- Coverage   59.30%   59.27%   -0.03%     
==========================================
  Files         580      580              
  Lines       38983    38983              
==========================================
- Hits        23118    23109       -9     
- Misses      14216    14222       +6     
- Partials     1649     1652       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nithyatsu nithyatsu merged commit f4f9f55 into radius-project:main Dec 10, 2024
28 of 29 checks passed
nithyatsu added a commit to nithyatsu/radius that referenced this pull request Dec 11, 2024
nithyatsu added a commit that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants