Refactor consistent query #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of each member maintaining a shared query_index updated by the heartbeat_rpc messages this commit changes the query_index to just maintain each member's local sequence that is only used when the member is a leader. This reduces some complexity in the algorithm as possibly avoids certain bugs.
|
Passes two runs of the jepsen test suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of each member maintaining a shared query_index updated by the heartbeat_rpc messages this commit changes the query_index to just maintain each member's local sequence that is only used when the member is a leader.
This reduces some complexity in the algorithm to possibly avoids certain bugs that could result from a follower retaining an old higher query index.
May fix #483