suppress git_protocol message in git_sitrep #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`git_protocol()` sets a default *and* messages the user if the option isn't already set. This message looks confusing in the output for `git_sitrep()`. This commit suppresses that messsage.
jennybc
reviewed
Aug 15, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2034
If the default git communication protocol isn't set,
git_protocol()sets a default and messages the user about the chosen default. That message looks confusing in the output bullets forgit_sitrep(). This PR suppresses that message.Putting
suppressMessages()directly in thekv_line()call didn't seem to work (maybe something about the environment?), so I split it into two steps.These chunks were useful for testing changes since I had some of these options set in my user-level .Rprofile: