hide margins if no overlay text #1951
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedre
reviewed
May 1, 2022
Comment on lines
+525
to
+532
| if(!didDraw){ | ||
| setPadding(horizontalSafeOffset, topSafeOffset, horizontalSafeOffset, bottomSafeOffset); | ||
| } else { | ||
| setPadding(horizontalSafeOffset, | ||
| topBottom + topSafeOffset, | ||
| horizontalSafeOffset, | ||
| topBottom + bottomSafeOffset); | ||
| } |
There was a problem hiding this comment.
jazakumAllah khairan - may we move this back into setIsScrollable with a check? this onDraw method gets called every frame, so we want to keep it as light as possible - whereas setIsScrollable just happens once
There was a problem hiding this comment.
I am not sure, but I don't see an easy way to move this block back to setIsScrollable, because setIsScrollable is not aware of what happens in onDraw
Some observations:
- show pages 1 and 2 (landscape, dual page) for the first time, then
setIsScrollableis executed 8 times andonDrawis executed 6 times. - swipe to pages 3 and 4, then
setIsScrollableis executed 2 times andonDrawis executed 4 times (reduces to 2 times when thisifblock is removed). - swipe back to pages 1 and 2, then only
setIsScrollableis executed twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.