fix: workaround to ensure terminal hyperlink is terminated correctly #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When testing a PR
gh notifs
hyperlink took over my terminal, which I raised #49 and cli/go-gh#150. This works around the issue by ensuring its terminated.I also considered just adding
printf '\e]8;;'
after line 21gh-my/includes/query_notifs
Line 21 in 58cdfb8
This would have at least stopped the command breaking the terminal, but each row was still broken
Changes
Thoughts
To be honest i'm not sure i like it, and possibly prefer just adding the print for the time being.