-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to reorder engine prioritization with engines
key in _quarto.yml
#11807
base: main
Are you sure you want to change the base?
Conversation
Hey, this is going to be an excellent addition to Quarto, thanks!
Sounds good, but this is something we'll definitely need tests for.
Did you try adding it to - name: engines
schema:
arrayOf: string
description: "..." |
@cscheid I have added tests. I also added an entry to the schema yml file you suggested, although I can't tell if it had an effect on anything. I was already allowed to put the From my side this PR is good to go otherwise. |
Small bump :) |
Am I mistaken to think this will also fix? Side note: what about |
Description
This PR adds the ability to change the order in which quarto checks if a markdown file or a language is claimed by an engine. This is necessary to allow users of the native julia engine to use it project-wide, without having to specify
engine: julia
in each notebook's frontmatter. This is because for backwards compatibility, the native julia engine neither claimed jl script files nor julia language blocks in qmd files, so that jupyter would continue to claim them as usual.Now, the julia engine does claim these properties, however, jupyter also does, and because the engines are checked in order, jupyter will always win by default. However, by specifying
engines: ['julia']
in_quarto.yml
, the native julia engine is checked first and therefore wins.This PR therefore fixes #10034 and #11305
Todos
I'm marking this WIP as I haven't added any tests, yet. First, I'd need to know that this approach is valid, for example if the location of the key in the config is correct. If it is, maybe some quarto-internal schema needs to be extended with this key as well, I couldn't quite make sense of that code when I tried to add
engines
below theproject
key at first. The top-level doesn't seem to get validated so I implemented the feature there.Checklist
I have (if applicable):