feat: added curved feature to axis component #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veinfors
reviewed
Nov 5, 2024
packages/picasso.js/src/core/chart-components/axis/axis-node-builder.js
Outdated
Show resolved
Hide resolved
veinfors
reviewed
Nov 5, 2024
packages/picasso.js/src/core/chart-components/axis/axis-node-builder.js
Outdated
Show resolved
Hide resolved
veinfors
reviewed
Nov 5, 2024
packages/picasso.js/src/core/chart-components/axis/axis-node-builder.js
Outdated
Show resolved
Hide resolved
veinfors
reviewed
Nov 6, 2024
packages/picasso.js/src/core/chart-components/axis/axis-arc-label-node.js
Outdated
Show resolved
Hide resolved
quanho
reviewed
Nov 7, 2024
packages/picasso.js/src/core/chart-components/axis/axis-default-settings.js
Outdated
Show resolved
Hide resolved
quanho
reviewed
Nov 7, 2024
packages/picasso.js/src/core/chart-components/axis/axis-node-builder.js
Outdated
Show resolved
Hide resolved
quanho
reviewed
Nov 7, 2024
packages/picasso.js/src/core/chart-components/axis/axis-node-builder.js
Outdated
Show resolved
Hide resolved
quanho
reviewed
Nov 7, 2024
packages/picasso.js/src/core/chart-components/axis/axis-node-builder.js
Outdated
Show resolved
Hide resolved
quanho
reviewed
Nov 7, 2024
packages/picasso.js/src/core/chart-components/axis/axis-node-builder.js
Outdated
Show resolved
Hide resolved
quanho
reviewed
Nov 7, 2024
packages/picasso.js/src/core/chart-components/axis/axis-arc-label-node.js
Outdated
Show resolved
Hide resolved
quanho
reviewed
Nov 7, 2024
packages/picasso.js/src/core/chart-components/axis/axis-arc-node.js
Outdated
Show resolved
Hide resolved
quanho
reviewed
Nov 7, 2024
packages/picasso.js/src/core/chart-components/axis/axis-arc-tick-node.js
Outdated
Show resolved
Hide resolved
|
It seems that the space calculations for tick labels are stricter than it should be. Look at 80,000,000.00 for example.
It seems that this is due to they way you select ticks in your other PR. So it's fine here. |
|
There seems to be a bug here that the 50,000,000.00 tick is smaller than the value (46,258,458.11)
But I think it's not caused by this PR (what's wrong is the position of the gauge indicator (the white line) but not the tick itself) |
bao-ho
reviewed
Nov 14, 2024
junit.xml
Outdated
There was a problem hiding this comment.
I don't think this file is necessary. Probably add it to git ignore.
| expect(result.anchor).to.equal('end'); | ||
| }); | ||
|
|
||
| it('start on left side of tick', () => { |
There was a problem hiding this comment.
two tests should not have the same name (this and the one above it)
bao-ho
reviewed
Nov 14, 2024
| expect(result.anchor).to.equal('end'); | ||
| }); | ||
|
|
||
| it('start on right side of tick', () => { |
There was a problem hiding this comment.
fix the expectation (make it more descriptive like the test below this)
bao-ho
reviewed
Nov 14, 2024
| it('Structure Properties', () => { | ||
| const rect = buildOpts.innerRect; | ||
| const centerPoint = { cx: rect.width / 2, cy: rect.height / 2 }; | ||
| const plotSize = Math.min(rect.height, rect.width) / 2; |
There was a problem hiding this comment.
fix name (probably fix in the main code as well), it should be halfPlotSize instead of plotSize
veinfors
reviewed
Nov 15, 2024
packages/picasso.js/src/core/chart-components/axis/__tests__/axis-arc-label-node.spec.js
Outdated
Show resolved
Hide resolved
veinfors
reviewed
Nov 15, 2024
packages/picasso.js/src/core/chart-components/axis/__tests__/axis-arc-tick-node.spec.js
Outdated
Show resolved
Hide resolved
veinfors
reviewed
Nov 15, 2024
packages/picasso.js/src/core/chart-components/axis/__tests__/axis-arc-label-node.spec.js
Outdated
Show resolved
Hide resolved
Moranski25
commented
Nov 18, 2024
quanho
approved these changes
Nov 18, 2024
veinfors
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added feature to the axis component. The feature creates a curved axis with ticks and labels if the "isRadial"-property is set to true. The axis-properties that are new are listed below.
arc:{
isRadial: boolean, (if not set defaults to false. Set to true for curved axis)
radius: number, (if not set, defaults to 0.5)
startAngle: number, (if not set, defaults to -pi/2)
endAngle: number, (if not set, defaults to pi/2)
}