Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copyrights #653

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Conversation

TolisChal
Copy link
Collaborator

@TolisChal TolisChal commented Jan 3, 2025

This PR fixes/updates the copyrights in the source code files.
Fixes this failed test: https://github.com/qiskit-community/qiskit-optimization/actions/runs/12596718193/job/35108371050

The test failed after merging #634 which developed in 2024.

@t-imamichi
Copy link
Collaborator

We update the copyright year when files are updated. check_copyright.py takes care of it automatically. So, you don't need to update all files manually.

@TolisChal
Copy link
Collaborator Author

We update the copyright year when files are updated. check_copyright.py takes care of it automatically. So, you don't need to update all files manually.

I used exactly that script to update them.

@woodsp-ibm
Copy link
Member

I am guessing this is to sort out the dates after #634 got merged this year just a short time ago, that PR being created and last updated, from the looks, last year. So while the dates would have passed and been correct had it been done in 2024 the fact it spilled over to this new year before it was merged I figure is the reason for this.

@TolisChal
Copy link
Collaborator Author

TolisChal commented Jan 3, 2025

I am guessing this is to sort out the dates after #634 got merged this year just a short time ago, that PR being created and last updated, from the looks, last year. So while the dates would have passed and been correct had it been done in 2024 the fact it spilled over to this new year before it was merged I figure is the reason for this.

Yes, exactly. After merging #634 the test for the copyrights failed. This PR fixes that failure.
I updated the description of this PR as well to be clear what it fixes.

Copy link
Collaborator

@t-imamichi t-imamichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Steve. I got it.

@TolisChal TolisChal merged commit 999ad95 into qiskit-community:main Jan 5, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants