Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop python 3.8 support #639

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Drop python 3.8 support #639

wants to merge 9 commits into from

Conversation

t-imamichi
Copy link
Collaborator

@t-imamichi t-imamichi commented Oct 17, 2024 •
edited
Loading

Summary

Addresses #638

qiskit-machine-learning also dropped the support of Python 3.8 already.
qiskit-community/qiskit-machine-learning#826

Details and comments

@t-imamichi t-imamichi changed the title Bump minimum supported python version to 3.9 (WIP) Bump minimum supported python version to 3.9 Oct 17, 2024
@t-imamichi t-imamichi changed the title (WIP) Bump minimum supported python version to 3.9 (WIP) Drop python 3.8 support Oct 18, 2024
@coveralls
Copy link

coveralls commented Oct 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12760379515

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 92.104%
Totals Coverage Status
Change from base Build 12622934125: 0.05%
Covered Lines: 5681
Relevant Lines: 6168
💛 - Coveralls

TolisChal
TolisChal previously approved these changes Nov 6, 2024
View reviewed changes
@TolisChal
Copy link
Collaborator

Thanks @t-imamichi! This PR looks good to me.

@t-imamichi t-imamichi changed the title (WIP) Drop python 3.8 support Drop python 3.8 support Nov 25, 2024
@t-imamichi t-imamichi marked this pull request as ready for review November 25, 2024 09:42
@t-imamichi
Copy link
Collaborator Author

Added a release note

Dniskk
Dniskk previously approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@Dniskk Dniskk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

TolisChal
TolisChal previously approved these changes Dec 16, 2024
View reviewed changes
@TolisChal
Copy link
Collaborator

LGTM!

@t-imamichi t-imamichi dismissed stale reviews from TolisChal and Dniskk via a577508 January 14, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dniskk Dniskk Dniskk left review comments

@TolisChal TolisChal TolisChal left review comments

@stefan-woerner stefan-woerner Awaiting requested review from stefan-woerner stefan-woerner is a code owner

@woodsp-ibm woodsp-ibm Awaiting requested review from woodsp-ibm woodsp-ibm is a code owner

@thkleinert thkleinert Awaiting requested review from thkleinert thkleinert is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t-imamichi @coveralls @TolisChal @Dniskk