Serialize CompositeAnalysis execution #1425
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CompositeAnalysis was calling run() on each subcomponent, which starts a new thread for each one, and then waiting on all of them to finish. Because of the way Python executes threads only one thread executes Python code at a time and there is not much performance benefit to starting all the threads at once. Here, the code is changed to wait for each subcomponent's run() to complete before starting the next one. Executing sequentially like this avoids starting an uncontrolled numbers of threads simultaneously. This is a temporary mitigation and a wider refactor should be done to handle analysis execution better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompositeAnalysis was calling run() on each subcomponent, which starts a new thread for each one, and then waiting on all of them to finish. Because of the way Python executes threads only one thread executes Python code at a time and there is not much performance benefit to starting all the threads at once. Here, the code is changed to wait for each subcomponent's run() to complete before starting the next one. Executing sequentially like this avoids starting an uncontrolled numbers of threads simultaneously.
This is a temporary mitigation and a wider refactor should be done to handle analysis execution better.