Skip to content

Commit

Permalink
Wording suggestions
Browse files Browse the repository at this point in the history
Co-authored-by: Will Shanks <[email protected]>
  • Loading branch information
nkanazawa1989 and wshanks committed Jan 10, 2024
1 parent 98c7e0d commit 6e2f441
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def estimate_minmax_frequencies(
coefficients: Dict[str, float],
max_amplitudes: Tuple[float, float] = (-0.9, 0.9),
) -> Tuple[float, float]:
"""Inquire maximum and minimum Stark shfit available within specified amplitude range.
"""Inquire maximum and minimum Stark shift available within specified amplitude range.
Args:
coefficients: A dictionary of Stark coefficients.
Expand All @@ -286,7 +286,7 @@ def estimate_minmax_frequencies(
if any(missing):
raise KeyError(
"Following coefficient data is missing in the "
f"'stark_coefficients' dictionary: {missing}."
f"stark 'coefficients' dictionary: {missing}."
)

names = cls.stark_coefficients_names # alias
Expand Down
6 changes: 3 additions & 3 deletions qiskit_experiments/library/characterization/t1.py
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,9 @@ def _default_experiment_options(cls) -> Options:
convert tone amplitudes into amount of Stark shift. This dictionary must include
all keys defined in :attr:`.StarkP1SpectAnalysis.stark_coefficients_names`,
which are calibrated with :class:`.StarkRamseyXYAmpScan`.
Alternatively, it searches for these coefficients in the result database
when "latest" is set. This requires having the experiment service set in
the experiment data to analyze.
Alternatively, a search for these coefficients in the result database is run
when "latest" is set. This requires having the experiment service available
in the ``backend`` set for the experiment.
"""
options = super()._default_experiment_options()
options.update_options(
Expand Down
6 changes: 3 additions & 3 deletions test/library/characterization/test_stark_p1_spect.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,9 @@ def test_scanning_frequency(self, po1, po2, po3, no1, no2, no3, ferr):
"""Test scanning frequency with experiment service.
This is a sort of round-trip test.
We generate amplitude from frequency through experimetn class.
this amplitude is converted into frequency again with the same coefficients.
Two frequencies must be consistent.
We generate amplitudes from frequencies through the experiment class.
These amplitudes are converted into frequencies again with the same coefficients.
The two sets of frequencies must be consistent.
"""
service = self.create_service_helper(po1, po2, po3, no1, no2, no3, ferr, 0, "fake_hanoi")

Expand Down

0 comments on commit 6e2f441

Please sign in to comment.