Features/api generator #122

bachue · 2024-01-04T05:31:36Z

KODO-19449
KODO-18801

qiniu-x · 2024-02-05T07:11:01Z

[Git-flow] Hi @bachue, There are some suggestions for your information:

Rebase suggestions

Following commits have duplicated messages

more apis in storage are rewritten by storagev2

more apis in storage are rewritten by storagev2

Which seems insignificant, recommend to use git rebase command to reorganize your PR.

For other git-flow instructions, recommend refer to these examples.

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-03-04T07:22:24Z

client/client.go

@@ -279,7 +284,7 @@ func ResponseError(resp *http.Response) error {
 func CallRet(ctx context.Context, ret interface{}, resp *http.Response) (err error) {

 	defer func() {
-		io.Copy(ioutil.Discard, resp.Body)
+		internal_io.SinkAll(resp.Body)


[golangci-lint] Error return value of internal_io.SinkAll is not checked (errcheck)

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-03-04T07:22:25Z

internal/clientv2/client.go

@@ -96,7 +98,7 @@ func DoAndDecodeJsonResponse(c Client, options RequestParams, ret interface{}) e
 	resp, err := Do(c, options)
 	defer func() {
 		if resp != nil && resp.Body != nil {
-			io.Copy(ioutil.Discard, resp.Body)
+			internal_io.SinkAll(resp.Body)


[golangci-lint] Error return value of internal_io.SinkAll is not checked (errcheck)

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-03-04T07:22:27Z

internal/clientv2/interceptor_retry_hosts.go

@@ -113,7 +117,7 @@ func (interceptor *hostsRetryInterceptor) Intercept(req *http.Request, handler H
 		req = reqBefore

 		if resp != nil && resp.Body != nil {
-			io.Copy(ioutil.Discard, resp.Body)
+			internal_io.SinkAll(resp.Body)


[golangci-lint] Error return value of internal_io.SinkAll is not checked (errcheck)

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-03-04T07:22:28Z

internal/io/io.go

+func ReadAll(r io.Reader) ([]byte, error) {
+	switch b := r.(type) {
+	case *BytesNopCloser:
+		b.Seek(0, io.SeekEnd)


[golangci-lint] Error return value of b.Seek is not checked (errcheck)

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-03-04T07:22:29Z

client/client.go

@@ -279,7 +284,7 @@ func ResponseError(resp *http.Response) error {
 func CallRet(ctx context.Context, ret interface{}, resp *http.Response) (err error) {

 	defer func() {
-		io.Copy(ioutil.Discard, resp.Body)
+		internal_io.SinkAll(resp.Body)


[golangci-lint] Error return value of internal_io.SinkAll is not checked (errcheck)

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-03-04T07:22:30Z

internal/clientv2/client.go

@@ -96,7 +98,7 @@ func DoAndDecodeJsonResponse(c Client, options RequestParams, ret interface{}) e
 	resp, err := Do(c, options)
 	defer func() {
 		if resp != nil && resp.Body != nil {
-			io.Copy(ioutil.Discard, resp.Body)
+			internal_io.SinkAll(resp.Body)


[golangci-lint] Error return value of internal_io.SinkAll is not checked (errcheck)

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-03-04T07:22:31Z

internal/clientv2/interceptor_retry_hosts.go

@@ -113,7 +117,7 @@ func (interceptor *hostsRetryInterceptor) Intercept(req *http.Request, handler H
 		req = reqBefore

 		if resp != nil && resp.Body != nil {
-			io.Copy(ioutil.Discard, resp.Body)
+			internal_io.SinkAll(resp.Body)


[golangci-lint] Error return value of internal_io.SinkAll is not checked (errcheck)

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-03-04T07:22:32Z

internal/io/io.go

+func ReadAll(r io.Reader) ([]byte, error) {
+	switch b := r.(type) {
+	case *BytesNopCloser:
+		b.Seek(0, io.SeekEnd)


[golangci-lint] Error return value of b.Seek is not checked (errcheck)

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-03-04T07:22:33Z

storagev2/internal/api-generator/request.go

+
+	if body := request.Body; body != nil {
+		if bodyJson := body.Json; bodyJson != nil {
+			bodyJson.generate(group, opts)


[golangci-lint] Error return value of bodyJson.generate is not checked (errcheck)

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-03-04T07:22:34Z

storagev2/internal/api-generator/response.go

+
+	if body := response.Body; body != nil {
+		if bodyJson := body.Json; bodyJson != nil {
+			bodyJson.generate(group, opts)


[golangci-lint] Error return value of bodyJson.generate is not checked (errcheck)

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-03-04T07:22:35Z

storagev2/uptoken/putpolicy.go

+
+// SetScope 指定上传的目标资源空间 Bucket 和资源键 Key
+func (putPolicy PutPolicy) SetScope(value string) PutPolicy {
+	putPolicy.Set(putPolicyKeyScope, value)


[golangci-lint] Error return value of putPolicy.Set is not checked (errcheck)

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-03-04T07:22:36Z

storagev2/uptoken/putpolicy.go

+
+// SetDeadline 指定上传策略有效截止时间
+func (putPolicy PutPolicy) SetDeadline(value int64) PutPolicy {
+	putPolicy.Set(putPolicyKeyDeadline, value)


[golangci-lint] Error return value of putPolicy.Set is not checked (errcheck)

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

qiniu-x · 2024-03-04T07:22:37Z

storagev2/uptoken/putpolicy.go

+
+// SetIsPrefixalScope 指定是否允许用户上传以 scope 的 keyPrefix 为前缀的文件
+func (putPolicy PutPolicy) SetIsPrefixalScope(value int64) PutPolicy {
+	putPolicy.Set(putPolicyKeyIsPrefixalScope, value)


[golangci-lint] Error return value of putPolicy.Set is not checked (errcheck)

If you have any questions about this comment, feel free to raise an issue here:

https://github.com/qiniu/reviewbot

…Body

…v2/http_client

… remove some useless json.Marshaler and json.Unmarshaler implementations, remove useless blocks

…n storagev2

…ot nil

bachue force-pushed the features/api-generator branch 5 times, most recently from 7f06a19 to 89b2da0 Compare January 5, 2024 08:04

YangSen-qn approved these changes Jan 5, 2024

View reviewed changes

bachue force-pushed the features/api-generator branch from 89b2da0 to 0c1b84a Compare January 12, 2024 03:22

qiniu-x bot reviewed Mar 4, 2024

View reviewed changes

bachue added 9 commits April 2, 2024 03:14

add internal cache

c1e51ed

add region for storagev2

49a3fd2

add credentials for storagev2

424ab03

add putpolicy for storagev2

a3254f3

add uptoken for storagev2

c98f9e0

add http_client

5a75706

fix the bug in BytesFromRequest

a490345

add api-generator & apis

b07430d

now we try to reuse BucketRegionsQueryer if the parameters are the same

7e2d1c7

bachue added 24 commits April 2, 2024 03:14

HttpClient.DoAndAcceptJSON won't return http.Response any more

af686ca

rename Cors => CORS

7afa42b

add comments to region

5704737

add comments to entry format

8c688cb

add MakeReadSeekCloserFromReader for internal/io

5c8cd25

remove Endpoints from HttpClientOptions

35932e0

add OverwrittenEndpoints and OverwrittenRegion to apis.Options

afc0e5f

now we could set request.ResponseBody to the struct type of response.…

323ea63

…Body

rewrite resume uploading by storagev2

9b20d62

now ObjectName in resumable_upload_v1_make_file can be nullable

9ac2e4d

rewrite form uploading by storagev2

b4ff403

use Region from cfg

b3d5a52

rewrite resume uploading by storagev2

ef19398

rename Queryer => Query

12bc19d

now delete_after_days in /deleteAfterDays are keepempty

4725a6e

export RetryConfig & Handler for storage/http_client

122d837

rename HTTPClient => Client, HTTPClientOptions => Options for storage…

8d3d698

…v2/http_client

now multipart binary type is http_client.MultipartFormBinaryData now,…

ee74bec

… remove some useless json.Marshaler and json.Unmarshaler implementations, remove useless blocks

fix days in addBucketRules & updateBucketRules

e74bef3

now queryCache only caches PersistentCache

27bcb53

fix json field name typo in get_objects

58b6f03

rename get_domains => get_bucket_domains

fd6d765

fix typo in docs

2b53d59

eliminate some lint errors

7b41f89

bachue force-pushed the features/api-generator branch from 507bb22 to 7b41f89 Compare April 2, 2024 03:15

bachue added 3 commits April 3, 2024 06:03

fix the issue that mkblk/mkfile/bput would always be failed to call i…

d7ee73d

…n storagev2

add ErrorCode for client.ErrorInfo

f46d7b8

now Credentials & UpToken field would be checked to make sure it is n…

6405266

…ot nil

bachue merged commit 6c9d7f5 into qiniu:master Apr 16, 2024
19 checks passed

bachue deleted the features/api-generator branch April 16, 2024 02:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Features/api generator #122

Features/api generator #122

bachue commented Jan 4, 2024 •

edited

Loading

qiniu-x bot commented Feb 5, 2024

qiniu-x bot Mar 4, 2024

qiniu-x bot Mar 4, 2024

qiniu-x bot Mar 4, 2024

qiniu-x bot Mar 4, 2024

qiniu-x bot Mar 4, 2024

qiniu-x bot Mar 4, 2024

qiniu-x bot Mar 4, 2024

qiniu-x bot Mar 4, 2024

qiniu-x bot Mar 4, 2024

qiniu-x bot Mar 4, 2024

qiniu-x bot Mar 4, 2024

qiniu-x bot Mar 4, 2024

qiniu-x bot Mar 4, 2024

Features/api generator #122

Features/api generator #122

Conversation

bachue commented Jan 4, 2024 • edited Loading

qiniu-x bot commented Feb 5, 2024

Rebase suggestions

qiniu-x bot Mar 4, 2024

Choose a reason for hiding this comment

qiniu-x bot Mar 4, 2024

Choose a reason for hiding this comment

qiniu-x bot Mar 4, 2024

Choose a reason for hiding this comment

qiniu-x bot Mar 4, 2024

Choose a reason for hiding this comment

qiniu-x bot Mar 4, 2024

Choose a reason for hiding this comment

qiniu-x bot Mar 4, 2024

Choose a reason for hiding this comment

qiniu-x bot Mar 4, 2024

Choose a reason for hiding this comment

qiniu-x bot Mar 4, 2024

Choose a reason for hiding this comment

qiniu-x bot Mar 4, 2024

Choose a reason for hiding this comment

qiniu-x bot Mar 4, 2024

Choose a reason for hiding this comment

qiniu-x bot Mar 4, 2024

Choose a reason for hiding this comment

qiniu-x bot Mar 4, 2024

Choose a reason for hiding this comment

qiniu-x bot Mar 4, 2024

Choose a reason for hiding this comment

bachue commented Jan 4, 2024 •

edited

Loading