Fix vertical anchor on font symbols to the baseline #60044
+148
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lculated with the same offset like the offset of the font. this differed before what leaded to issues. still the old way is available as legacy
… setting for this mode making a differene between legacy and baseline (and future bounds) on the positioning of the characters
|
I'd like to review this but can't for the next couple of weeks. please do not merge before then! |
|
@nyalldawson Cool. I hoped for your feedback, since you already brought up your thoughts in the issue. Since it's definitely a bug (although a side case) it would be great to have it in the upcoming LTR. Hope this can still be possible. |
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Test comments are outdated and no longer valid (now hidden) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Font Marker Symbols an offset ("off1" in the sketch) is appended to the coordinates to know where to start drawing the symbol (at "point"). This offset is half of the scaled defined size (what later defines the size from baseline to top of a sign without accents). On the other hand, an offset ("off2") is appended to this point concerning the vertical anchor (top, bottom, center). This second offset ("off2") was not half of the scaled defined size, but the half of the distance between baseline and the FontMetric Ascent - and these two measurements differed! What leaded to the wrong placement (alpha and beta)...
With this fix, the two offsets are always calculated the same, which leads to a correct position of the FontMarkers on Bottom.
Means before on bottom (example with Font DejaVu Sans and CadastraSymbol):
Now:
Fixes #59732
Since this fix should not affect positions of markers in existing projects, we had to append a new setting instead of replacing the old. With the implementation of calculating the positions with bounds (like mentioned in this issue #59732) the existing anchor types should become legacy. This is prepared in the following implementation, having a verticalAnchorMode in the FontMarker. As well it's provided that when I configure a Font Marker with a Bottom on Baseline, then change the marker to an SVG Marker, the anchor is Bottom, and when I go back to Font Marker it's Bottom on Baseline again.
What about "Top on Baseline" (and Center)?
With this fix as well the Top and the Center Anchors would differ on the
verticalAnchorMode:Baseline. But since it's not really recognizable and - I think - rarely used, I did not add it to the settings. But the backend with theverticalAnchorMode, would be prepared to add them on request.The implementation of the bounds might follow. I see what I can do...