-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pasting unsaved changes as temporary scratch layers #57985
base: master
Are you sure you want to change the base?
Conversation
Does this work if you modify QgsField::convertCompatible to add something like this just after the initial null check?
|
|
They shouldn't be! Are you checking the field type or value type? |
Value type is string, field type should be int. I can see |
@nyalldawson when |
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
Description
Pasting unsaved changes as a temporary scratch layer could fail when source is a db.
Geopackages would have
Autogenerate
as an fid value, Postgres layers would havenextval(...
values etc, which could not be stored in the target int field.Instead of failing, this PR continues with a null value instead.
Fixes #38913