[3D] Add support for data defined properties of points #57929

ptitjano · 2024-06-28T14:17:33Z

Description

This PR introduces support for data defined properties (radius, length...). This needs some changes in QgsInstancedPoint3DSymbolHandler. Inded, it uses OpenGL instancing in order to draw multiple times the same entity at different locations with the same shape. In practice, this means that only 2 Qt3D entities are
created:

1 for the points which are not selected
1 for the selected points
Indeed, the selected points do not have the same color as the normal ones. If there isn't any selected point, only one entity is created.

When a point can have a data defined shapes, this logic needs to be updated. The idea is to group the points which have the same shape. This logic is handled by the PointData class and the == operator. If two different have the same state (selected or normal) and the same shape, they are grouped together in the same PointData
instance and their respective positions are stored in positions. With that logic, the following entities are created:

Entity1: (normal, radius1, length1)
Entity2: (selected, radius1, length1)
Entity3: (normal, radius1, lenght2)
Entity4: (selected, radius1, lenght2)
Entity5: (normal, radius2, lenght1)
Entity6: (selected, radius2, lenght1)
Entity5: (normal, radius2, lenght2)
Entity6: (selected, radius2, lenght2)
...

If there is only one shape, the previous case still applies.

Example

This will be used by `QgsPoint3DSymbol` in the next commit.

`QgsInstancedPoint3DSymbolHandler` uses OpenGL instancing in order to draw multiple times the same entity at different locations with the same shape. In practice, this means that only two Qt3D entities are created: - one for the points which are not selected - one for the selected points Indeed, the selected points do not have the same color as the normal ones. If there isn't any selected point, only one entity is created. When a point can have a data defined radius, this logic needs to be updated. The idea is to group the points which have the same radius. This logic is handled by the `PointData` class and the `==` operator. If two different have the same state (selected or normal) and the same radius, they are grouped together in the same `PointData` instance and their respective positions are stored in `positions`. This means that if there are 3 different radii, at most 6 different entities are created: 1. Entity1: (normal, radius1) 2. Entity2: (selected, radius1) 3. Entity3: (normal, radius2) 4. Entity4: (selected, radius2) 5. Entity5: (normal, radius3) 6. Entity6: (selected, radius3) If there is only one radius, the previous case still applies.

This will be used by `QgsPoint3DSymbol` in the next commit.

src/3d/symbols/qgspoint3dsymbol_p.cpp

benoitdm-oslandia · 2024-06-28T14:35:49Z

src/core/3d/qgsabstract3dsymbol.h

+      BottomRadius SIP_MONKEYPATCH_COMPAT_NAME( PropertyHeight ), //!< Bottom Radius
+      MinorRadius SIP_MONKEYPATCH_COMPAT_NAME( PropertySize ), //!< Minor Radius
+      TopRadius SIP_MONKEYPATCH_COMPAT_NAME( PropertyHeight ), //!< Top Radius
+      Size SIP_MONKEYPATCH_COMPAT_NAME( PropertySize ), //!< Size


Size is not a reserved word?

I don't know.

github-actions · 2024-06-28T14:49:17Z

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit c5cc462)

nyalldawson · 2024-06-28T20:34:37Z

I'm wondering how well this approach scales. Eg if you had a point layer with thousands of points , and each has there own distinct height, we'll end up with a LOT of entities. Have you tested to see what the usable limits are? I suspect we would need some way to abort creating new entities early if we approach the usable limit...

github-actions · 2024-07-13T02:39:28Z

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

wonder-sk · 2024-07-18T21:28:08Z

I have the same concerns as Nyall - this approach will likely not perform well when used with slightly larger datasets, with many thousands of draw commands required. The correct solution here is to add data-defined properties to vertex buffers and handle sizing in the vertex shader code...

github-actions · 2024-08-02T02:41:04Z

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

github-actions · 2024-08-20T02:41:54Z

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

github-actions · 2024-09-04T02:45:14Z

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

qgis-bot · 2024-09-24T08:41:20Z

@ptitjano

This pull request has been tagged for the changelog.

The description will be harvested so please provide a "nearly-ready" text for the final changelog
If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits

Funded by NAME
Funded by URL
Funded by NAME URL
Sponsored by NAME
Sponsored by URL
Sponsored by NAME URL

Thank you!

ptitjano · 2024-09-27T14:29:38Z

I have the same concerns as Nyall - this approach will likely not perform well when used with slightly larger datasets, with many thousands of draw commands required. The correct solution here is to add data-defined properties to vertex buffers and handle sizing in the vertex shader code...

I tried to apply your suggestion but I don't know how to write some vertex shader code which could handle the data defined properties. For example, how would it be possible to handle the length of a cylinder?
Or, do you think that this should be handled with some geometry shader code?

nyalldawson · 2024-09-30T03:47:29Z

@ptitjano checkout the (unmerged, unfinished) PR at #55849 -- there's likely some parts of that approach you could use

github-actions · 2024-10-15T02:47:49Z

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

github-actions · 2024-12-18T02:50:05Z

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

github-actions · 2024-12-26T02:47:14Z

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

ptitjano added 2 commits June 28, 2024 10:56

qgspoint3dsymbol_p: Fix a clang-tidy warning

fff3288

qgsabstract3dsymbol: Add radius symbol definition

7d47f24

This will be used by `QgsPoint3DSymbol` in the next commit.

github-actions bot added this to the 3.40.0 milestone Jun 28, 2024

ptitjano added Feature 3D Relates to QGIS' 3D engine or rendering labels Jun 28, 2024

ptitjano self-assigned this Jun 28, 2024

ptitjano added 14 commits June 28, 2024 16:23

qgspoint3dsymbolwidget: Add support for data defined radius

016e755

qgsabstract3dsymbol: Add length symbol definition

0c0a500

This will be used by `QgsPoint3DSymbol` in the next commit.

qgspoint3dsymbol: Add support for data defined length

be6e0b2

qgspoint3dsymbolwidget: Add support for data defined length

7c229b0

qgsabstract3dsymbol: Add size symbol definition

03d2338

This will be used by `QgsPoint3DSymbol` in the next commit.

qgspoint3dsymbol: Add support for data defined size

480fdc5

qgspoint3dsymbolwidget: Add support for data defined size

44f7fd7

qgsabstract3dsymbol: Add bottom/top radius symbol definition

3543d95

This will be used by `QgsPoint3DSymbol` in the next commit.

qgspoint3dsymbol: Add support for data defined bottom/top radius

8f6cdae

qgspoint3dsymbolwidget: Add support for data defined bottom/top radius

592244b

qgsabstract3dsymbol: Add minor radius symbol definition

f28c724

This will be used by `QgsPoint3DSymbol` in the next commit.

qgspoint3dsymbol: Add support for data defined minor radius

2ef348a

qgspoint3dsymbolwidget: Add support for data defined minor radius

db63491

ptitjano force-pushed the data-defined-point-3d-part1 branch from 171a697 to db63491 Compare June 28, 2024 14:23

benoitdm-oslandia reviewed Jun 28, 2024

View reviewed changes

qgspoint3dsymbol_p: Add comments to instanced handler functions

c5cc462

github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jul 13, 2024

github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jul 18, 2024

github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 2, 2024

ptitjano removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 5, 2024

github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 20, 2024

ptitjano removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 20, 2024

github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 4, 2024

ptitjano removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 4, 2024

nyalldawson added the Freeze Exempt Feature Freeze exemption granted label Sep 13, 2024

zacharlie added the Changelog Items that are queued to appear in the visual changelog - remove after harvesting label Sep 24, 2024

github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Oct 15, 2024

nyalldawson added Frozen Feature freeze - Do not merge! and removed Freeze Exempt Feature Freeze exemption granted labels Oct 17, 2024

ptitjano removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Oct 17, 2024

nyalldawson removed the Frozen Feature freeze - Do not merge! label Dec 4, 2024

github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Dec 18, 2024

github-actions bot closed this Dec 26, 2024

ptitjano reopened this Jan 9, 2025

github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[3D] Add support for data defined properties of points #57929

[3D] Add support for data defined properties of points #57929

ptitjano commented Jun 28, 2024

benoitdm-oslandia Jun 28, 2024

ptitjano Jun 28, 2024

github-actions bot commented Jun 28, 2024 •

edited

Loading

nyalldawson commented Jun 28, 2024

github-actions bot commented Jul 13, 2024

wonder-sk commented Jul 18, 2024

github-actions bot commented Aug 2, 2024

github-actions bot commented Aug 20, 2024

github-actions bot commented Sep 4, 2024

qgis-bot commented Sep 24, 2024

ptitjano commented Sep 27, 2024

nyalldawson commented Sep 30, 2024

github-actions bot commented Oct 15, 2024

github-actions bot commented Dec 18, 2024

github-actions bot commented Dec 26, 2024

[3D] Add support for data defined properties of points #57929

Are you sure you want to change the base?

[3D] Add support for data defined properties of points #57929

Conversation

ptitjano commented Jun 28, 2024

Description

Example

benoitdm-oslandia Jun 28, 2024

Choose a reason for hiding this comment

ptitjano Jun 28, 2024

Choose a reason for hiding this comment

github-actions bot commented Jun 28, 2024 • edited Loading

🪟 Windows builds ready!

nyalldawson commented Jun 28, 2024

github-actions bot commented Jul 13, 2024

wonder-sk commented Jul 18, 2024

github-actions bot commented Aug 2, 2024

github-actions bot commented Aug 20, 2024

github-actions bot commented Sep 4, 2024

qgis-bot commented Sep 24, 2024

ptitjano commented Sep 27, 2024

nyalldawson commented Sep 30, 2024

github-actions bot commented Oct 15, 2024

github-actions bot commented Dec 18, 2024

github-actions bot commented Dec 26, 2024

github-actions bot commented Jun 28, 2024 •

edited

Loading