Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the handling of AMVs unit to units by applying suggestion in #2898 #3031

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+25 −35

Add ssp_lon to the dict of attribute to be tested

d42c00d
Select commit
Loading
Failed to load commit list.
Open

Fix the handling of AMVs unit to units by applying suggestion in #2898 #3031

Add ssp_lon to the dict of attribute to be tested
d42c00d
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jan 15, 2025 in 54s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.15 (9.17 -> 9.31)

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Code Duplication test_fci_l2_nc.py: TestFciL2NCAMVFileHandler.test_all_basic

Annotations

Check notice on line 1 in satpy/tests/reader_tests/test_fci_l2_nc.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Code Duplication 

reduced similar code in: TestFciL2NCAMVFileHandler.test_all_basic. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
View more details on CodeScene Delta Analysis